linux-kernel - Re: [PATCH 4/4] dt-bindings: iio: light: Simplify interrupts property in the example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <623783cf-d1ca-424c-9e71-e14acb9c3204@ixit.cz>
Date: Thu, 24 Jul 2025 13:22:36 +0200
From: David Heidelberg <david@...t.cz>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Andy Shevchenko <andy@...nel.org>,
 Ceclan Dumitru <dumitru.ceclan@...log.com>,
 Michael Hennerich <Michael.Hennerich@...log.com>,
 Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 Alexandru Lazar <alazar@...rtmail.com>,
 linux-arm-kernel@...ts.infradead.org, Bjorn Andersson
 <andersson@...nel.org>, Stephan Gerhold <stephan@...hold.net>,
 Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>,
 Angelo Compagnucci <angelo.compagnucci@...il.com>,
 Marcelo Schmitt <marcelo.schmitt@...log.com>, Ondřej Jirman
 <megi@....cz>, David Lechner <dlechner@...libre.com>,
 linux-iio@...r.kernel.org, Matti Vaittinen <mazziesaccount@...il.com>,
 Mike Looijmans <mike.looijmans@...ic.nl>,
 Puranjay Mohan <puranjay@...nel.org>, Manivannan Sadhasivam
 <mani@...nel.org>, Peter Meerwald-Stadler <pmeerw@...erw.net>,
 linux-samsung-soc@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
 Dan Robertson <dan@...obertson.com>, Linus Walleij
 <linus.walleij@...aro.org>, Stefan Popa <stefan.popa@...log.com>,
 Dragos Bogdan <dragos.bogdan@...log.com>,
 Alexandru Tachici <alexandru.tachici@...log.com>,
 Nuno Sá <nuno.sa@...log.com>,
 Jonathan Cameron <jic23@...nel.org>,
 Lucas Stankus <lucas.p.stankus@...il.com>, linux-kernel@...r.kernel.org,
 Andreas Klinger <ak@...klinger.de>, Andy Gross <agross@...nel.org>
Subject: Re: [PATCH 4/4] dt-bindings: iio: light: Simplify interrupts property
 in the example

Thank you,

Reviewed-by: David Heidelberg <david@...t.cz>

On 24/07/2025 13:13, Krzysztof Kozlowski wrote:
> dynaimage,al3010 and dynaimage,al3320a are I2C devices, so their
> interrupts are not routed to GIC and rarely first interrupt cell is <0>.
> This looks like copy-paste from some SoC block, so drop it and also for
> readability use known defines instead of hard-coding interrupt flag.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   .../devicetree/bindings/iio/light/dynaimage,al3010.yaml         | 2 +-
>   .../devicetree/bindings/iio/light/dynaimage,al3320a.yaml        | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml b/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
> index f1048c30e73e..1472c997c16f 100644
> --- a/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/dynaimage,al3010.yaml
> @@ -42,6 +42,6 @@ examples:
>               compatible = "dynaimage,al3010";
>               reg = <0x1c>;
>               vdd-supply = <&vdd_reg>;
> -            interrupts = <0 99 4>;
> +            interrupts = <99 IRQ_TYPE_LEVEL_HIGH>;
>           };
>       };
> diff --git a/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml b/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml
> index 8249be99cff9..d06db737cd9e 100644
> --- a/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/dynaimage,al3320a.yaml
> @@ -40,6 +40,6 @@ examples:
>               compatible = "dynaimage,al3320a";
>               reg = <0x1c>;
>               vdd-supply = <&vdd_reg>;
> -            interrupts = <0 99 4>;
> +            interrupts = <99 IRQ_TYPE_LEVEL_HIGH>;
>           };
>       };

-- 
David Heidelberg