[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4ab97f28-ac2c-44d8-847c-d3a49e4f38a6@oss.qualcomm.com>
Date: Thu, 24 Jul 2025 13:32:47 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: srinivas.kandagatla@....qualcomm.com, andersson@...nel.org,
konradybcio@...nel.org
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
cros-qcom-dts-watchers@...omium.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/23] arm64: dts: qcom: x1e80100: move dsp audio nodes to
dedicated dts
On 7/24/25 12:27 AM, srinivas.kandagatla@....qualcomm.com wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
>
> All the device tree nodes for audioreach dsp are duplicated across all
> the SoC dtsi files, Move this to a dedicated dtsi file so to remove some
> duplication, make it consistent across all device trees and also make it
> easy for new SoC's to add audio support.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
> ---
[...]
> - gpr {
> - compatible = "qcom,gpr";
> - qcom,glink-channels = "adsp_apps";
This seems to never change, maybe we can add some internal bus-like
matching to glink that we could put a cookie in the GPR driver for?
> - qcom,domain = <GPR_DOMAIN_ID_ADSP>;
Similarly, this never changes (unless call audio would go through
modem and require a similar structure or something, I really don't
know)
> - qcom,intents = <512 20>;
This is also always the very same
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - q6apm: service@1 {
> - compatible = "qcom,q6apm";
> - reg = <GPR_APM_MODULE_IID>;
> - #sound-dai-cells = <0>;
> - qcom,protection-domain = "avs/audio",
> - "msm/adsp/audio_pd";
These never change either
Konrad
Powered by blists - more mailing lists