linux-kernel - Re: [PATCH] iio: adc: ad7280a: Remove unused macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aIIg3m1eXC3dNfeM@smile.fi.intel.com>
Date: Thu, 24 Jul 2025 15:02:38 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Salah Triki <salah.triki@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7280a: Remove unused macros

On Thu, Jul 24, 2025 at 11:54:23AM +0100, Salah Triki wrote:
> This is to fix the following warnings when compiling the ad7280a driver using
> LLVM=1 and W=2:

W=2 ?! No, please don't do that. W=2 is for informative purposes. Better spend
your efforts against W=1 which are still plenty in the kernel.


On top of that, often the definitions is a (arguable not the best) piece of
documentation of the HW, we don't drop them because they are unused (today).

NAK.

-- 
With Best Regards,
Andy Shevchenko