linux-kernel - Re: [PATCH v5 3/3] treewide: Switch from tsk->comm to tsk->comm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6fec26c9-b240-6548-c970-882c0576ef33@igalia.com>
Date: Thu, 24 Jul 2025 18:08:10 +0530
From: Bhupesh Sharma <bhsharma@...lia.com>
To: Askar Safin <safinaskar@...omail.com>, bhupesh@...lia.com
Cc: akpm@...ux-foundation.org, alexei.starovoitov@...il.com,
 andrii.nakryiko@...il.com, arnaldo.melo@...il.com, bpf@...r.kernel.org,
 brauner@...nel.org, bsegall@...gle.com, david@...hat.com,
 ebiederm@...ssion.com, jack@...e.cz, juri.lelli@...hat.com, kees@...nel.org,
 keescook@...omium.org, kernel-dev@...lia.com, laoar.shao@...il.com,
 linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, linux-perf-users@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, lkp@...el.com,
 mathieu.desnoyers@...icios.com, mgorman@...e.de, mingo@...hat.com,
 mirq-linux@...e.qmqm.pl, oliver.sang@...el.com, peterz@...radead.org,
 pmladek@...e.com, rostedt@...dmis.org, torvalds@...ux-foundation.org,
 viro@...iv.linux.org.uk, vschneid@...hat.com, willy@...radead.org
Subject: Re: [PATCH v5 3/3] treewide: Switch from tsk->comm to tsk->comm_str
 which is 64 bytes long


On 7/24/25 2:46 PM, Askar Safin wrote:
>> where TASK_COMM_EXT_LEN is 64-bytes.
> Why 64? As well as I understand, comm is initialized from executable file name by default. And it is usually limited by 256 (or 255?) bytes. So, please, make limit 256 bytes.
>
>
Check existing users like proc_task_name(), which use 64-byte comm names:

void proc_task_name(struct seq_file *m, struct task_struct *p, bool escape)
{
        char tcomm[64];
        ....


Hence, it was decided not to change this and other similar existing 
users and cap tsk->comm to 64-bytes.

Thanks,
Bhupesh