linux-kernel - Re: [PATCH v2 1/1] iio: adc: ad4170-4: Correctly update filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250724135125.5dabddb1@jic23-huawei>
Date: Thu, 24 Jul 2025 13:51:25 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Marcelo Schmitt <marcelo.schmitt@...log.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, dan.carpenter@...aro.org, lars@...afoo.de,
 Michael.Hennerich@...log.com, dlechner@...libre.com, nuno.sa@...log.com,
 andy@...nel.org, Markus.Elfring@....de, marcelo.schmitt1@...il.com
Subject: Re: [PATCH v2 1/1] iio: adc: ad4170-4: Correctly update filter_fs
 after filter type change

On Mon, 21 Jul 2025 14:43:38 +0300
Andy Shevchenko <andriy.shevchenko@...el.com> wrote:

> On Sun, Jul 20, 2025 at 12:37:24PM -0300, Marcelo Schmitt wrote:
> > Previously, the driver was directly using the filter type value to update
> > the filter frequency (filter_fs) configuration. That caused the driver to
> > switch to the lowest filter_fs configuration (highest sampling frequency)
> > on every update to the filter type. Correct the filter_fs collateral update
> > by clamping it to the range of supported values instead of mistakenly
> > using the filter type to update the filter_fs.
> > 
> > Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> > Link: https://lore.kernel.org/linux-iio/c6e54942-5b42-484b-be53-9d4606fd25c4@sabinyo.mountain/  
> 
> You mean Closes: here?
> 
> > Suggested-by: Jonathan Cameron <jic23@...nel.org>
> > Fixes: 8ab7434734cd ("iio: adc: ad4170-4: Add digital filter and sample frequency config support")
> > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@...log.com>  
> 

I picked up v1 and made that a closes tag.  Links to email threads are fine
(there was a question in v1 on this).

Applied to the fixes-togreg-for-6.17 branch.