linux-kernel - Re: [PATCH v3 10/13] ARM: dts: aspeed: Add Facebook Fuji-data64 (AST2600) Board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <769d6817-ee97-4a23-b013-29bc875a00cb@lunn.ch>
Date: Thu, 24 Jul 2025 14:53:39 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Tao Ren <rentao.bupt@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
	Andrew Jeffery <andrew@...econstruct.com.au>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Tao Ren <taoren@...a.com>
Subject: Re: [PATCH v3 10/13] ARM: dts: aspeed: Add Facebook Fuji-data64
 (AST2600) Board

On Wed, Jul 23, 2025 at 06:03:49PM -0700, Tao Ren wrote:
> On Thu, Jul 24, 2025 at 02:03:20AM +0200, Andrew Lunn wrote:
> > > +&mac3 {
> > > +	status = "okay";
> > > +	phy-mode = "rgmii";
> > 
> > Does the PCB have extra long clock lines to implement the 2ns delay?
> > 
> > 	Andrew
> 
> Hi Andrew,
> 
> Thank you for catching it. I didn't notice the settings because the file
> is copied from the exiting fuji.dts with minor changes.
> 
> The delay is currently introduced on MAC side (by manually setting SCU
> registers), but I guess I can update phy-mode to "rgmii-id" so the delay
> can be handled by the PHY?

That would be good, if it works. The problem with the current code is
that those SCU registers are not set as part of the MAC driver, so it
is hard to know what value they have.

	Andrew