linux-kernel - Re: [PATCH v4] iio: adc: ad7173: add SPI offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250724141215.07319298@jic23-huawei>
Date: Thu, 24 Jul 2025 14:12:15 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Michael Hennerich <Michael.Hennerich@...log.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v4] iio: adc: ad7173: add SPI offload support

On Thu, 10 Jul 2025 17:22:00 -0500
David Lechner <dlechner@...libre.com> wrote:

> Enable SPI offload support for the AD7173 ADC driver.
> 
> The scan_type used for SPI offload is assuming that we are using the
> ad411x_ad717x HDL project [1] which always stores data words in 32-bits.
> 
> Link: https://analogdevicesinc.github.io/hdl/projects/ad411x_ad717x/index.html [1]
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: David Lechner <dlechner@...libre.com>
I'm going to be optimistic that we don't have any clashes in this new feature
patches with the fix I just queued up.

Applied to the testing branch of iio.git.

thanks,

Jonathan

> ---
> v3 was applied, but then we had to drop the final patch due to a
> conflicting fix. Here is that patch again with the changes needed to
> adjust it to the changes in the fix.
> 
> We'll have to wait for the fix to make it's way back into iio/testing
> before we can apply this patch, so it will have to sit for a while.
> 
> v4 changes:
> - Add one more instance of .supports_spi_offload = true,.
> - Picked up Andy's Reviewed-by tag.
> ---
>  drivers/iio/adc/ad7173.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index 9730fda56186afc45f589899e669c41eb538af6b..3886d2f751d0370994ababf72409f4dcb328641d 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -747,6 +747,7 @@ static const struct ad_sigma_delta_info ad7173_sigma_delta_info_4_slots = {
>  	.set_mode = ad7173_set_mode,
>  	.has_registers = true,
>  	.has_named_irqs = true,
> +	.supports_spi_offload = true,
>  	.addr_shift = 0,
>  	.read_mask = BIT(6),
>  	.status_ch_mask = GENMASK(3, 0),
> @@ -763,6 +764,7 @@ static const struct ad_sigma_delta_info ad7173_sigma_delta_info_8_slots = {
>  	.set_mode = ad7173_set_mode,
>  	.has_registers = true,
>  	.has_named_irqs = true,
> +	.supports_spi_offload = true,
>  	.addr_shift = 0,
>  	.read_mask = BIT(6),
>  	.status_ch_mask = GENMASK(3, 0),
> @@ -779,6 +781,7 @@ static const struct ad_sigma_delta_info ad7173_sigma_delta_info_16_slots = {
>  	.set_mode = ad7173_set_mode,
>  	.has_registers = true,
>  	.has_named_irqs = true,
> +	.supports_spi_offload = true,
>  	.addr_shift = 0,
>  	.read_mask = BIT(6),
>  	.status_ch_mask = GENMASK(3, 0),
> @@ -1595,6 +1598,11 @@ static int ad7173_fw_parse_channel_config(struct iio_dev *indio_dev)
>  		if (st->info->data_reg_only_16bit)
>  			chan_arr[chan_index].scan_type = ad4113_scan_type;
>  
> +		if (ad_sigma_delta_has_spi_offload(&st->sd)) {
> +			chan_arr[chan_index].scan_type.storagebits = 32;
> +			chan_arr[chan_index].scan_type.endianness = IIO_CPU;
> +		}
> +
>  		chan_index++;
>  	}
>  
> @@ -1685,6 +1693,12 @@ static int ad7173_fw_parse_channel_config(struct iio_dev *indio_dev)
>  		if (st->info->data_reg_only_16bit)
>  			chan_arr[chan_index].scan_type = ad4113_scan_type;
>  
> +		/* Assuming SPI offload is ad411x_ad717x HDL project. */
> +		if (ad_sigma_delta_has_spi_offload(&st->sd)) {
> +			chan_arr[chan_index].scan_type.storagebits = 32;
> +			chan_arr[chan_index].scan_type.endianness = IIO_CPU;
> +		}
> +
>  		chan_index++;
>  	}
>  	return 0;
> 
> ---
> base-commit: f8f559752d573a051a984adda8d2d1464f92f954
> change-id: 20250620-iio-adc-ad7173-add-spi-offload-support-32a178b666a3
> prerequisite-change-id: 20250703-iio-adc-ad7173-fix-num_slots-on-most-chips-b982206a20b1:v3
> prerequisite-patch-id: 350fb675f3e0fe494e0ce4ddf5685d9369ffa11a
> 
> Best regards,