linux-kernel - RE: [PATCH] HID: Intel-thc-hid: Intel-thc: Use str_true

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6098588380705B3778770C46F45EA@IA1PR11MB6098.namprd11.prod.outlook.com>
Date: Thu, 24 Jul 2025 03:07:10 +0000
From: "Xu, Even" <even.xu@...el.com>
To: "liu.xuemei1@....com.cn" <liu.xuemei1@....com.cn>, "jikos@...nel.org"
	<jikos@...nel.org>, "bentiss@...nel.org" <bentiss@...nel.org>
CC: "Sun, Xinpeng" <xinpeng.sun@...el.com>,
	"srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>,
	"liu.song13@....com.cn" <liu.song13@....com.cn>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] HID: Intel-thc-hid: Intel-thc: Use str_true_false()
 helper



> -----Original Message-----
> From: liu.xuemei1@....com.cn <liu.xuemei1@....com.cn>
> Sent: Thursday, July 24, 2025 10:36 AM
> To: jikos@...nel.org; bentiss@...nel.org
> Cc: Xu, Even <even.xu@...el.com>; Sun, Xinpeng <xinpeng.sun@...el.com>;
> srinivas.pandruvada@...ux.intel.com; liu.song13@....com.cn; linux-
> input@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] HID: Intel-thc-hid: Intel-thc: Use str_true_false() helper
> 
> From: Liu Song <liu.song13@....com.cn>
> 
> Remove hard-coded strings by using the str_true_false() helper function.
> 
> Signed-off-by: Liu Song <liu.song13@....com.cn>
> ---
>  drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c b/drivers/hid/intel-
> thc-hid/intel-thc/intel-thc-dev.c
> index 6f2263869b20..2b794bb481a0 100644
> --- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
> +++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
> @@ -4,6 +4,7 @@
>  #include <linux/bitfield.h>
>  #include <linux/math.h>
>  #include <linux/regmap.h>
> +#include <linux/string_choices.h>
> 
>  #include "intel-thc-dev.h"
>  #include "intel-thc-hw.h"
> @@ -664,7 +665,7 @@ int thc_interrupt_quiesce(const struct thc_device *dev,
> bool int_quiesce)
>  	if (ret) {
>  		dev_err_once(dev->dev,
>  			     "Timeout while waiting THC idle, target quiesce state
> = %s\n",
> -			     int_quiesce ? "true" : "false");
> +			     str_true_false(int_quiesce));
>  		return ret;
>  	}
> 

Thanks for the patch! Looks good to me!

Reviewed-by: Even Xu <even.xu@...el.com>

> --
> 2.27.0