| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1c4a5faf-7c1f-4d84-9a9f-ec88b3e6c860@infradead.org>
Date: Fri, 25 Jul 2025 14:12:53 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>,
Linux Next Mailing List <linux-next@...r.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Krzysztof Kozlowski <krzk@...nel.org>, netdev@...r.kernel.org
Subject: Re: linux-next: Tree for Jul 25 (nfc/nfrmrvl/ and nfc/s3fwrn5/)
On 7/24/25 7:48 PM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20250724:
>
on ARCH=um SUBARCH=x86_64, when
# CONFIG_GPIOLIB is not set
../drivers/nfc/nfcmrvl/main.c: In function ‘nfcmrvl_nci_register_dev’:
../drivers/nfc/nfcmrvl/main.c:115:13: error: implicit declaration of function ‘gpio_is_valid’; did you mean ‘uuid_is_valid’? [-Wimplicit-function-declaration]
115 | if (gpio_is_valid(priv->config.reset_n_io)) {
| ^~~~~~~~~~~~~
| uuid_is_valid
../drivers/nfc/nfcmrvl/main.c:116:22: error: implicit declaration of function ‘gpio_request_one’ [-Wimplicit-function-declaration]
116 | rc = gpio_request_one(priv->config.reset_n_io,
| ^~~~~~~~~~~~~~~~
../drivers/nfc/nfcmrvl/main.c:117:39: error: ‘GPIOF_OUT_INIT_LOW’ undeclared (first use in this function)
117 | GPIOF_OUT_INIT_LOW,
| ^~~~~~~~~~~~~~~~~~
../drivers/nfc/nfcmrvl/main.c:117:39: note: each undeclared identifier is reported only once for each function it appears in
../drivers/nfc/nfcmrvl/main.c:176:17: error: implicit declaration of function ‘gpio_free’; did you mean ‘kfifo_free’? [-Wimplicit-function-declaration]
176 | gpio_free(priv->config.reset_n_io);
| ^~~~~~~~~
| kfifo_free
../drivers/nfc/nfcmrvl/main.c: In function ‘nfcmrvl_chip_reset’:
../drivers/nfc/nfcmrvl/main.c:238:17: error: implicit declaration of function ‘gpio_set_value’; did you mean ‘pte_set_val’? [-Wimplicit-function-declaration]
238 | gpio_set_value(priv->config.reset_n_io, 0);
| ^~~~~~~~~~~~~~
| pte_set_val
../drivers/nfc/s3fwrn5/phy_common.c: In function ‘s3fwrn5_phy_set_wake’:
../drivers/nfc/s3fwrn5/phy_common.c:22:9: error: implicit declaration of function ‘gpio_set_value’; did you mean ‘pte_set_val’? [-Wimplicit-function-declaration]
22 | gpio_set_value(phy->gpio_fw_wake, wake);
| ^~~~~~~~~~~~~~
| pte_set_val
../drivers/nfc/s3fwrn5/i2c.c: In function ‘s3fwrn5_i2c_parse_dt’:
../drivers/nfc/s3fwrn5/i2c.c:158:14: error: implicit declaration of function ‘gpio_is_valid’; did you mean ‘uuid_is_valid’? [-Wimplicit-function-declaration]
158 | if (!gpio_is_valid(phy->common.gpio_en)) {
| ^~~~~~~~~~~~~
| uuid_is_valid
../drivers/nfc/s3fwrn5/i2c.c: In function ‘s3fwrn5_i2c_probe’:
../drivers/nfc/s3fwrn5/i2c.c:200:15: error: implicit declaration of function ‘devm_gpio_request_one’ [-Wimplicit-function-declaration]
200 | ret = devm_gpio_request_one(&phy->i2c_dev->dev, phy->common.gpio_en,
| ^~~~~~~~~~~~~~~~~~~~~
../drivers/nfc/s3fwrn5/i2c.c:201:37: error: ‘GPIOF_OUT_INIT_HIGH’ undeclared (first use in this function)
201 | GPIOF_OUT_INIT_HIGH, "s3fwrn5_en");
| ^~~~~~~~~~~~~~~~~~~
../drivers/nfc/s3fwrn5/i2c.c:201:37: note: each undeclared identifier is reported only once for each function it appears in
../drivers/nfc/s3fwrn5/i2c.c:207:37: error: ‘GPIOF_OUT_INIT_LOW’ undeclared (first use in this function)
207 | GPIOF_OUT_INIT_LOW, "s3fwrn5_fw_wake");
| ^~~~~~~~~~~~~~~~~~
../drivers/nfc/s3fwrn5/uart.c: In function ‘s3fwrn82_uart_parse_dt’:
../drivers/nfc/s3fwrn5/uart.c:100:14: error: implicit declaration of function ‘gpio_is_valid’; did you mean ‘uuid_is_valid’? [-Wimplicit-function-declaration]
100 | if (!gpio_is_valid(phy->common.gpio_en))
| ^~~~~~~~~~~~~
| uuid_is_valid
../drivers/nfc/s3fwrn5/uart.c: In function ‘s3fwrn82_uart_probe’:
../drivers/nfc/s3fwrn5/uart.c:147:15: error: implicit declaration of function ‘devm_gpio_request_one’ [-Wimplicit-function-declaration]
147 | ret = devm_gpio_request_one(&phy->ser_dev->dev, phy->common.gpio_en,
| ^~~~~~~~~~~~~~~~~~~~~
../drivers/nfc/s3fwrn5/uart.c:148:37: error: ‘GPIOF_OUT_INIT_HIGH’ undeclared (first use in this function)
148 | GPIOF_OUT_INIT_HIGH, "s3fwrn82_en");
| ^~~~~~~~~~~~~~~~~~~
../drivers/nfc/s3fwrn5/uart.c:148:37: note: each undeclared identifier is reported only once for each function it appears in
../drivers/nfc/s3fwrn5/uart.c:154:37: error: ‘GPIOF_OUT_INIT_LOW’ undeclared (first use in this function)
154 | GPIOF_OUT_INIT_LOW, "s3fwrn82_fw_wake");
|
Possibly this:
---
drivers/nfc/nfcmrvl/Kconfig | 3 +++
drivers/nfc/s3fwrn5/Kconfig | 3 +++
2 files changed, 6 insertions(+)
--- linux-next-20250725.orig/drivers/nfc/nfcmrvl/Kconfig
+++ linux-next-20250725/drivers/nfc/nfcmrvl/Kconfig
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config NFC_MRVL
tristate
+ depends on GPIOLIB
help
The core driver to support Marvell NFC devices.
@@ -10,6 +11,7 @@ config NFC_MRVL
config NFC_MRVL_USB
tristate "Marvell NFC-over-USB driver"
depends on NFC_NCI && USB
+ depends on GPIOLIB
select NFC_MRVL
help
Marvell NFC-over-USB driver.
@@ -23,6 +25,7 @@ config NFC_MRVL_USB
config NFC_MRVL_UART
tristate "Marvell NFC-over-UART driver"
depends on NFC_NCI && NFC_NCI_UART
+ depends on GPIOLIB
select NFC_MRVL
help
Marvell NFC-over-UART driver.
--- linux-next-20250725.orig/drivers/nfc/s3fwrn5/Kconfig
+++ linux-next-20250725/drivers/nfc/s3fwrn5/Kconfig
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config NFC_S3FWRN5
tristate
+ depends on GPIOLIB
select CRYPTO
select CRYPTO_HASH
help
@@ -11,6 +12,7 @@ config NFC_S3FWRN5
config NFC_S3FWRN5_I2C
tristate "Samsung S3FWRN5 I2C support"
depends on NFC_NCI && I2C
+ depends on GPIOLIB
select NFC_S3FWRN5
default n
help
@@ -24,6 +26,7 @@ config NFC_S3FWRN5_I2C
config NFC_S3FWRN82_UART
tristate "Samsung S3FWRN82 UART support"
depends on NFC_NCI && SERIAL_DEV_BUS
+ depends on GPIOLIB
select NFC_S3FWRN5
help
This module adds support for a UART interface to the S3FWRN82 chip.
--
~Randy
Powered by blists - more mailing lists