linux-kernel - Re: [PATCH 1/1] dt-bindings: mmc: fsl,esdhc: Add explicit reference to mmc-controller-common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250725233554.GA2028042-robh@kernel.org>
Date: Fri, 25 Jul 2025 18:35:54 -0500
From: Rob Herring <robh@...nel.org>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Ulf Hansson <ulf.hansson@...aro.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Frank Li <Frank.Li@....com>,
	linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: mmc: fsl,esdhc: Add explicit reference
 to mmc-controller-common

On Fri, Jul 25, 2025 at 08:01:51AM +0200, Alexander Stein wrote:
> Even though it is referenced by mmc/mmc-controller.yaml it still raises
> the warning:
>   esdhc@...0000 (fsl,ls1021a-esdhc): Unevaluated properties are not allowed ('bus-width' was unexpected)
> 
> Adding an explicit reference fixes this.
> 
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
> I don't know if this is a tooling problem or whatever. I would have
> expected that mmc-controller-common.yaml is added via
> mmc-controller.yaml. But apparently this is missing resulting in the
> given warning. Hence adding the reference

The issue is the nodename. Since validation of it fails, the whole 
referenced schema is not 'evaluated' and bus-width is unevaluated. Best 
I can tell, that's correct behavior for json-schema.

I guess this is an adequate work-around.

Acked-by: Rob Herring (Arm) <robh@...nel.org>

> 
>  Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
> index 62087cf920df8..f45e592901e24 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
> @@ -90,6 +90,7 @@ required:
>  
>  allOf:
>    - $ref: sdhci-common.yaml#
> +  - $ref: mmc-controller-common.yaml#
>  
>  unevaluatedProperties: false
>  
> -- 
> 2.43.0
>