linux-kernel - Re: [PATCH v7 18/31] x86/resctrl: Count valid telemetry aggregators per package

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba0eebf2-12e7-4783-bfb6-81773d3b25b1@intel.com>
Date: Fri, 25 Jul 2025 16:40:09 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v7 18/31] x86/resctrl: Count valid telemetry aggregators
 per package

Hi Tony,

On 7/11/25 4:53 PM, Tony Luck wrote:
> There may be multiple telemetry aggregators per package, each enumerated
> by a telemetry region structure in the feature group.
> 
> Scan the array of telemetry region structures and count how many are
> in each package in preparation to allocate structures to save the MMIO
> addresses for each in a convenient format for use when reading event
> counters.
> 
> Sanity check that the telemetry region structures have a valid
> package_id and that the size they report for the MMIO space is as

package_id -> package id

> large as expected from the XML description of the registers in
> the region.

The above two paragraphs seem to describe the actual flow backwards:
first is mentions that telemetry regions are counted (above implies that
all telemetry regions are counted, valid as well as invalid) and then how
to actually determine if a telemetry region is valid?
It will be less confusing to first describe how it is determined that a
telemetry region is valid and then it will be easier to explain that only
*valid* telemetry regions are counted?

> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---

Patch looks good.

Reinette