linux-kernel - Re: [PATCH v7 21/31] x86,fs/resctrl: Add architectural event pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a77c6173-69d2-493c-b566-5ab447f019ef@intel.com>
Date: Fri, 25 Jul 2025 16:43:40 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v7 21/31] x86,fs/resctrl: Add architectural event pointer

Hi Tony,

On 7/11/25 4:53 PM, Tony Luck wrote:
> The resctrl file system layer passed the domain, rmid, and event id to

passed -> passes
rmid -> RMID

> resctrl_arch_rmid_read() to fetch an event counter.
> 
> For some resources this may not be enough information to efficiently

"For some resources this may" this is vague and speculative. This can be
made definitive because there is a clear problem solved by this, for example, 
"Fetching a telemetry event counter requires additional information that is
private to the architecture, for example, the offset into MMIO space from where
counter should be read."

> access the counter.
> 
> Add mon_evt::arch_priv void pointer. Architecture code can initialize
> this when marking each event enabled.
> 
> File system code passes this pointer to resctrl_arch_rmid_read().
> 
> Suggested-by: Reinette Chatre <reinette.chatre@...el.com>
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---

Reinette