[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ccf6db60-2fd9-4d83-8ed8-68e600664fcf@intel.com>
Date: Fri, 25 Jul 2025 16:46:25 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
<Dave.Martin@....com>, Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
<patches@...ts.linux.dev>
Subject: Re: [PATCH v7 24/31] x86/resctrl: Add energy/perf choices to rdt boot
option
Hi Tony,
On 7/11/25 4:53 PM, Tony Luck wrote:
> #define NUM_RDT_OPTIONS ARRAY_SIZE(rdt_options)
>
> @@ -865,6 +869,32 @@ bool rdt_cpu_has(int flag)
> return ret;
> }
>
> +/*
> + * Hardware features that do not have X86_FEATURE_* bits.
> + * There is no "hardware does not support this at all" case.
> + * Assume that the caller has already determined that
> + * support is present and just needs to check if the option has been
nit: "that support is present" -> "that hardware support is present"
option -> feature?
> + * disabled by a quirk that has not been overridden by a command
> + * line option.
> + */
Reinette
Powered by blists - more mailing lists