linux-kernel - Re: [PATCH] PCI: mvebu: Use devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aIMAkbdOyHsiPeph@pc>
Date: Fri, 25 Jul 2025 04:57:05 +0100
From: Salah Triki <salah.triki@...il.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Pali Rohár <pali@...nel.org>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: mvebu: Use devm_add_action_or_reset()

On Thu, Jul 24, 2025 at 11:42:17AM -0500, Bjorn Helgaas wrote:
> On Sat, Jul 19, 2025 at 05:34:40AM +0100, Salah Triki wrote:
> 
>   ret = devm_add_action_or_reset(dev, clk_put, port->clk)
> 
The second argument of devm_add_action_or_reset() is of type void (*)(void *)
and the argument of clk_put() is of type struct clk *, so I think a cast is
needed:

ret = devm_add_action_or_reset(dev, (void (*)(void *)) clk_put, port->clk)

Best regards,
Salah Triki