linux-kernel - Re: [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use correct IRQ level in example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPLW+4=XmFYvD1tmXXX53ORHp-Ued3_tCZoFCi=ch35aBuYO5Q@mail.gmail.com>
Date: Thu, 24 Jul 2025 23:34:54 -0500
From: Sam Protsenko <semen.protsenko@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, 
	Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>, 
	Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Lucas Stankus <lucas.p.stankus@...il.com>, Puranjay Mohan <puranjay@...nel.org>, 
	Dan Robertson <dan@...obertson.com>, Marcelo Schmitt <marcelo.schmitt@...log.com>, 
	Alim Akhtar <alim.akhtar@...sung.com>, Dragos Bogdan <dragos.bogdan@...log.com>, 
	Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>, Ondřej Jirman <megi@....cz>, 
	Alexandru Tachici <alexandru.tachici@...log.com>, Stefan Popa <stefan.popa@...log.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Stephan Gerhold <stephan@...hold.net>, 
	Ceclan Dumitru <dumitru.ceclan@...log.com>, Alexandru Lazar <alazar@...rtmail.com>, 
	Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>, 
	Matti Vaittinen <mazziesaccount@...il.com>, 
	Angelo Compagnucci <angelo.compagnucci@...il.com>, Mike Looijmans <mike.looijmans@...ic.nl>, 
	David Heidelberg <david@...t.cz>, Manivannan Sadhasivam <mani@...nel.org>, 
	Peter Meerwald-Stadler <pmeerw@...erw.net>, Andreas Klinger <ak@...klinger.de>, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: iio: adc: samsung,exynos-adc: Use
 correct IRQ level in example

On Thu, Jul 24, 2025 at 6:14 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> The interrupt line to GIC is IRQ_TYPE_LEVEL_HIGH, so use that instead of
> "none".  Also replace the hard-coded GIC_SPI flag.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@...aro.org>

>  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml    | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index 4e40f6bed5db..8069e99ddac8 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -128,10 +128,12 @@ allOf:
>
>  examples:
>    - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
>      adc: adc@...10000 {
>          compatible = "samsung,exynos-adc-v1";
>          reg = <0x12d10000 0x100>;
> -        interrupts = <0 106 0>;
> +        interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
>          #io-channel-cells = <1>;
>
>          clocks = <&clock 303>;
> @@ -152,11 +154,12 @@ examples:
>
>    - |
>      #include <dt-bindings/clock/exynos3250.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>
>      adc@...c0000 {
>          compatible = "samsung,exynos3250-adc";
>          reg = <0x126c0000 0x100>;
> -        interrupts = <0 137 0>;
> +        interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
>          #io-channel-cells = <1>;
>
>          clocks = <&cmu CLK_TSADC>,
> --
> 2.48.1
>
>