linux-kernel - Re: [PATCH] usb: xhci: print xhci->xhc_state when queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40390378-714d-4f46-8e13-93ec3c75f2f2@nfschina.com>
Date: Fri, 25 Jul 2025 13:11:42 +0800
From: Su Hui <suhui@...china.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: mathias.nyman@...el.com, linux-usb@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Su Hui <suhui@...china.com>
Subject: Re: [PATCH] usb: xhci: print xhci->xhc_state when queue_command
 failed

On 2025/7/25 12:43, Greg KH wrote:
> On Fri, Jul 25, 2025 at 11:13:09AM +0800, Su Hui wrote:
>> When encounters some errors like these:
>> xhci_hcd 0000:4a:00.2: xHCI dying or halted, can't queue_command
>> xhci_hcd 0000:4a:00.2: FIXME: allocate a command ring segment
>> usb usb5-port6: couldn't allocate usb_device
>>
>> It's hard to know whether xhc_state is dying or halted. So it's better
>> to print xhc_state's value which can help locate the resaon of the bug.
>>
>> Signed-off-by: Su Hui <suhui@...china.com>
>> ---
>>   drivers/usb/host/xhci-ring.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
>> index 94c9c9271658..a1a628e849c0 100644
>> --- a/drivers/usb/host/xhci-ring.c
>> +++ b/drivers/usb/host/xhci-ring.c
>> @@ -4372,7 +4372,8 @@ static int queue_command(struct xhci_hcd *xhci, struct xhci_command *cmd,
>>   
>>   	if ((xhci->xhc_state & XHCI_STATE_DYING) ||
>>   		(xhci->xhc_state & XHCI_STATE_HALTED)) {
>> -		xhci_dbg(xhci, "xHCI dying or halted, can't queue_command\n");
>> +		xhci_dbg(xhci, "xHCI dying or halted, can't queue_command. state: %u\n",
>> +			 xhci->xhc_state);
> Don't you want to see this value in hex?

yes, hex is better, will update in v2 soon.

Su Hui