linux-kernel - Re: [PATCH] PCI: controller: use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1736b3c9-dd02-4014-b6d9-4897f4e97d64@kernel.org>
Date: Fri, 25 Jul 2025 07:37:00 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: bhelgaas@...gle.com, tglx@...utronix.de, linux-kernel@...r.kernel.org,
 Jingoo Han <jingoohan1@...il.com>, Manivannan Sadhasivam <mani@...nel.org>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Rob Herring <robh@...nel.org>,
 Karthikeyan Mitran <m.karthikeyan@...iveil.co.in>,
 Hou Zhiqiang <Zhiqiang.Hou@....com>, Joyce Ooi <joyce.ooi@...el.com>,
 Ryder Lee <ryder.lee@...iatek.com>, Jianjun Wang
 <jianjun.wang@...iatek.com>, Michal Simek <michal.simek@....com>,
 Daire McNamara <daire.mcnamara@...rochip.com>, linux-pci@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 Arnd Bergmann <arnd@...db.de>, Nam Cao <namcao@...utronix.de>
Subject: Re: [PATCH] PCI: controller: use dev_fwnode()

On 25. 07. 25, 1:10, Bjorn Helgaas wrote:
> [+cc Arnd, Nam]
> 
> On Wed, Jul 23, 2025 at 08:59:07AM +0200, Jiri Slaby (SUSE) wrote:
>> All irq_domain functions now accept fwnode instead of of_node. But many
>> PCI controllers still extract dev to of_node and then of_node to fwnode.
>>
>> Instead, clean this up and simply use the dev_fwnode() helper to extract
>> fwnode directly from dev. Internally, it still does dev => of_node =>
>> fwnode steps, but it's now hidden from the users.
>>
>> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
>> Link: https://lore.kernel.org/all/4ee9c7c0-4a3f-4afa-ae5a-7fd8a750c92b@kernel.org/
>> Link: https://lore.kernel.org/all/4bc0e1ca-a523-424a-8759-59e353317fba@kernel.org/
> 
> Thanks, Jiri, I applied this on pci/controller/msi-parent for v6.17;
> it's at
> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=controller/msi-parent
> 
> The dev_fwnode() conversions touched the same places as Nam's changes
> to use msi_create_parent_irq_domain().  The previous dev_fwnode()
> conversions were *before* Nam's changes and these are *after*, and it
> all ended up looking more complicated than I wanted, so I squashed all
> the dev_fwnode() conversions together in
> https://git.kernel.org/cgit/linux/kernel/git/pci/pci.git/commit/?id=a103d2dede56
> ("PCI: controller: Use dev_fwnode() instead of of_fwnode_handle()")
> and then added Nam's msi_create_parent_irq_domain() patches on top.
> 
> So a103d2dede56 ("PCI: controller: Use dev_fwnode() instead of
> of_fwnode_handle()") ends up *looking* different from the patch below,
> but I think having them all together makes it more obvious that
> they're all making the same conversion, and I think the end result is
> identical.

Makes sense to me.

Thanks!

-- 
js
suse labs