linux-kernel - Re: [PATCH] checkpatch: validate commit tag ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53eb0068-008b-48e6-9b92-d92de2ed4fc9@kernel.org>
Date: Fri, 25 Jul 2025 10:42:20 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hendrik Hamerlinck <hendrik.hamerlinck@...mernet.be>,
 dwaipayanray1@...il.com, lukas.bulwahn@...il.com, joe@...ches.com,
 corbet@....net, apw@...onical.com
Cc: skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linux.dev,
 workflows@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: validate commit tag ordering

On 24/07/2025 09:20, Hendrik Hamerlinck wrote:
> Modified the checkpatch script to ensure that commit tags (e.g.,
> Signed-off-by, Reviewed-by, Acked-by, Tested-by, etc.) appear in the
> correct order according to kernel conventions [1].

These are not the conventions I use for my subsystems and ask others to
follow, so imposing TIP rules to all maintainers needs broad consensus,
not (yet) checkpatch.

What's more, I think above TIP rules are contradicting with existing,
widely used and approved toolset - b4. So no, if you want universal
tool, please use b4 or whatever b4 defines.

Best regards,
Krzysztof