linux-kernel - Re: [PATCH v2 5/8] media: platform: amd: isp4 subdev and firmware loading handling added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <820992ca-479a-40fe-82bd-8ca46cd2fb14@amd.com>
Date: Fri, 25 Jul 2025 17:03:09 +0800
From: "Du, Bin" <bin.du@....com>
To: Sultan Alsawaf <sultan@...neltoast.com>
Cc: mchehab@...nel.org, hverkuil@...all.nl,
 laurent.pinchart+renesas@...asonboard.com, bryan.odonoghue@...aro.org,
 sakari.ailus@...ux.intel.com, prabhakar.mahadev-lad.rj@...renesas.com,
 linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 pratap.nirujogi@....com, benjamin.chan@....com, king.li@....com,
 gjorgji.rosikopulos@....com, Phil.Jawich@....com, Dominic.Antony@....com,
 Svetoslav.Stoilov@....com
Subject: Re: [PATCH v2 5/8] media: platform: amd: isp4 subdev and firmware
 loading handling added

Thanks Sultan, will fix it in the next patch

Regards,
Bin

On 7/25/2025 9:35 AM, Sultan Alsawaf wrote:
> On Wed, Jun 18, 2025 at 05:19:56PM +0800, Bin Du wrote:
>> +static int isp4_parse_fwnode_init_async_nf(struct isp4_device *isp_dev)
>> +{
>> +	struct isp4_subdev *isp_sdev = &isp_dev->isp_sdev;
>> +	struct device *dev = &isp_dev->pdev->dev;
>> +	struct v4l2_fwnode_endpoint bus_cfg = {
>> +		.bus_type = V4L2_MBUS_CSI2_DPHY
>> +	};
>> +	struct fwnode_handle *remote_ep = NULL;
>> +	struct fwnode_handle *local_ep = NULL;
> 
> [snip]
> 
>> +err_fwnode:
>> +	if (remote_ep)
>> +		fwnode_handle_put(remote_ep);
>> +	if (local_ep)
>> +		fwnode_handle_put(remote_ep);
> 
> Copy/paste error: the second fwnode_handle_put() should put `local_ep`.
> 
>> +
>> +	return ret;
>> +}
> 
> Sultan