linux-kernel - Re: [PATCH v2 19/20] clk: sp7021: switch to FIELD_PREP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175340605069.3513.18204498860033427106@lazor>
Date: Thu, 24 Jul 2025 18:14:10 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Alexandre Torgue <alexandre.torgue@...s.st.com>, Andrew Lunn <andrew+netdev@...n.ch>, Andy Yan <andy.yan@...k-chips.com>, Bill Wendling <morbo@...gle.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Chanwoo Choi <cw00.choi@...sung.com>, David Airlie <airlied@...il.com>, David S. Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Heiko Stuebner <heiko@...ech.de>, Jaehoon Chung <jh80.chung@...sung.com>, Jakub Kicinski <kuba@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Justin Stitt <justinstitt@...gle.com>, Kishon Vijay Abraham I <kishon@...nel.org>, Krzysztof Wilczyński <kwilczynski@...nel.org>, Kyungmin Park <kyungmin.park@...sung.com>, Liam Girdwood <lgirdwood@...il.com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Manivannan Sadhasivam <mani@...nel.org>, Mark Brown <broonie@...nel.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Maxime Ripard <mripard@k
 ernel.org>, Michael Turquette <mturquette@...libre.com>, MyungJoo Ham <myungjoo.ham@...sung.com>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <nick.desaulniers+lkml@...il.com>, Nicolas Frattaroli <frattaroli.nicolas@...il.com>, Nicolas Frattaroli <nicolas.frattaroli@...labora.com>, Paolo Abeni <pabeni@...hat.com>, Qin Jian <qinjian@...lus1.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Rob Herring <robh@...nel.org>, Sandy Huang <hjc@...k-chips.com>, Shawn Lin <shawn.lin@...k-chips.com>, Shreeya Patel <shreeya.patel@...labora.com>, Simona Vetter <simona@...ll.ch>, Takashi Iwai <tiwai@...e.com>, Thomas Zimmermann <tzimmermann@...e.de>, Ulf Hansson <ulf.hansson@...aro.org>, Vinod Koul <vkoul@...nel.org>, Yury Norov <yury.norov@...il.com>
Cc: kernel@...labora.com, linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-phy@...ts.infradead.org, linux-sound@...r.kernel.org, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-pci@...r.kernel.org, linux-pm@...r.kernel.org, linux-clk@...r.kernel.org, llvm@...ts.linux.dev, Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
Subject: Re: [PATCH v2 19/20] clk: sp7021: switch to FIELD_PREP_WM16 macro

Quoting Nicolas Frattaroli (2025-06-23 09:05:47)
> The sp7021 clock driver has its own shifted high word mask macro,
> similar to the ones many Rockchip drivers have.
> 
> Remove it, and replace instances of it with hw_bitfield.h's
> FIELD_PREP_WM16 macro, which does the same thing except in a common
> macro that also does compile-time error checking.
> 
> This was compile-tested with 32-bit ARM with Clang, no runtime tests
> were performed as I lack the hardware. However, I verified that fix
> commit 5c667d5a5a3e ("clk: sp7021: Adjust width of _m in HWM_FIELD_PREP()")
> is not regressed. No warning is produced.

Does it generate the same code before and after?