[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAP4=nvQde7JcbhR56--4EfEsJ+F9oL4WBCRcLaOqfV1MZ-XvjQ@mail.gmail.com>
Date: Fri, 25 Jul 2025 11:13:43 +0200
From: Tomas Glozar <tglozar@...hat.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Ivan Pravdin <ipravdin.official@...il.com>, bristot@...nel.org, corbet@....net,
linux-trace-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtla: clarify trace option syntax in documentation and
usage help
čt 24. 7. 2025 v 15:59 odesílatel Steven Rostedt <rostedt@...dmis.org> napsal:
>
> On Tue, 22 Jul 2025 21:52:33 -0400
> Ivan Pravdin <ipravdin.official@...il.com> wrote:
> > Valid usage:
> > - `-t[file]`
> > - `-t=[file]`
> > - `--trace=[file]`
> >
> > Invalid usage:
> > - `-t [file]`
> > - `--trace [file]`
>
> I wonder if the better fix would be to make the above valid?
>
Definitely. There is also another case where only = syntax is
accepted, C/--cgroup. In my opinion, both are confusing, and both
should accept = as well as space. I even had some trouble with the
latter as it fails to parse silently and looks like the cgroup setting
code is not working.
Tomas
Powered by blists - more mailing lists