linux-kernel - Re: [PATCH] clocksource/drivers/exynos_mct: Revert commits causing section mismatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f413942-8126-4d94-b64b-c4a05052b5a1@linaro.org>
Date: Fri, 25 Jul 2025 11:35:29 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Daniel Lezcano <daniel.lezcano@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>, Krzysztof Kozlowski <krzk@...nel.org>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 Will McVicker <willmcvicker@...gle.com>,
 Youngmin Nam <youngmin.nam@...sung.com>, Donghoon Yu <hoony.yu@...sung.com>,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/exynos_mct: Revert commits causing
 section mismatches

On 25/07/2025 11:28, Daniel Lezcano wrote:
> On 25/07/2025 11:03, Krzysztof Kozlowski wrote:
>> Commit 5d86e479193b ("clocksource/drivers/exynos_mct: Add module
>> support") introduced section mismatch failures.
>> Commit 7e477e9c4eb4 ("clocksource/drivers/exynos_mct: Fix section
>> mismatch from the module conversion") replaced these to other section
>> mismatch failures:
>>
>>    WARNING: modpost: vmlinux: section mismatch in reference: mct_init_dt+0x164 (section: .text) -> register_current_timer_delay (section: .init.text)
>>    WARNING: modpost: vmlinux: section mismatch in reference: mct_init_dt+0x20c (section: .text) -> register_current_timer_delay (section: .init.text)
>>    ERROR: modpost: Section mismatches detected.
>>
>> No progress on real fixing of these happened (intermediary fix was still
>> not tested), so revert both commits till the work is prepared correctly.
> 
> Please don't claim the fix was not tested. I reproduced the section 


section mismatch code MUST BE tested with enabled DEBUG_SECTION_MISMATCH
and disabled SECTION_MISMATCH_WARN_ONLY. If you have warnings which you
missed (although if you have warnings what did you fix?), means you did
not prepare testing setup.

> mismatch, tested it and figured out it was indeed fixing the issue. I 
> just missed the error because it sounds very close to the first one 
> reported initially and I did the confusion.
> 
> The driver is not supposed to be compiled as a module on ARM32.
> 
> The option tristate "Exynos multi core timer driver" if ARM64 is 
> misleading. From this change, the defconfig on ARM can do 
> CONFIG_EXYNOS_MCT=m which should not be allowed.
> 
> Before getting wild and revert everything, let's try to find a proper 
> fix for that.

I am not wild here. The issue is there since 9 days.

Best regards,
Krzysztof