linux-kernel - Re: [PATCH v4 1/4] dt-bindings: hwmon: Add MPS mp2869,mp29608,mp29612 and mp29816 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cccad21e-7599-4643-9f39-94faf482041d@roeck-us.net>
Date: Fri, 25 Jul 2025 02:38:52 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Krzysztof Kozlowski <krzk@...nel.org>, wenswang@...h.net
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 jdelvare@...e.com, corbet@....net, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: hwmon: Add MPS mp2869,mp29608,mp29612
 and mp29816 series

On 7/25/25 00:21, Krzysztof Kozlowski wrote:
> On Thu, Jul 24, 2025 at 05:13:03PM +0800, wenswang@...h.net wrote:
>> From: Wensheng Wang <wenswang@...h.net>
>>
>> Add support for MPS mp2869/mp2869a,mp29608/mp29608a,mp29612/mp29612a and
>> mp29816/mp29816a/mp29816b/mp29816c controller
>>
>> Acked-by: Rob Herring (Arm) <robh@...nel.org>
>> Signed-off-by: Wensheng Wang <wenswang@...h.net>
>> ---
>> V3 -> V4:
>>      1. split patches for MP2869,mp29608,mp29612,mp29816,mp29502
>>      2. add description for vender specific registers
>>
>> V2 -> V3:
>>      merge patches for MP2869,mp29608,mp29612,mp29816,mp29502
> 
> No one asked you to merge drivers. Look where comments appear.
> 
> So again: merge the bindings, it's a churn to add one trivial device
> after another.
> 

I think that is what they did in this version of the series. There are
two drivers for the various chips, one of them supporting multiple chips.
That makes sense if the supported chips are similar (and afaics that
is the case).

Guenter