linux-kernel - Re: [PATCH 30/38] arm64: dts: mediatek: pumpkin-common: Fix pinctrl node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC=S1niM4ddPSaOM9uMRQuUS8HwPw+gtxe9kGUggWQx6uio5eA@mail.gmail.com>
Date: Fri, 25 Jul 2025 18:17:35 +0800
From: Fei Shao <fshao@...omium.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: linux-mediatek@...ts.infradead.org, robh@...nel.org, 
	daniel.lezcano@...aro.org, mwalle@...nel.org, devicetree@...r.kernel.org, 
	linus.walleij@...aro.org, linux-remoteproc@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	olivia.wen@...iatek.com, shane.chien@...iatek.com, linux-gpio@...r.kernel.org, 
	linux-phy@...ts.infradead.org, airlied@...il.com, simona@...ll.ch, 
	herbert@...dor.apana.org.au, jassisinghbrar@...il.com, jiaxin.yu@...iatek.com, 
	andy.teng@...iatek.com, chunfeng.yun@...iatek.com, jieyy.yang@...iatek.com, 
	chunkuang.hu@...nel.org, conor+dt@...nel.org, jitao.shi@...iatek.com, 
	p.zabel@...gutronix.de, arnd@...db.de, kishon@...nel.org, 
	kyrie.wu@...iatek.corp-partner.google.com, maarten.lankhorst@...ux.intel.com, 
	tinghan.shen@...iatek.com, mripard@...nel.org, ck.hu@...iatek.com, 
	broonie@...nel.org, eugen.hristev@...aro.org, houlong.wei@...iatek.com, 
	matthias.bgg@...il.com, tglx@...utronix.de, mchehab@...nel.org, 
	linux-arm-kernel@...ts.infradead.org, granquet@...libre.com, 
	sam.shih@...iatek.com, mathieu.poirier@...aro.org, fparent@...libre.com, 
	andersson@...nel.org, sean.wang@...nel.org, linux-sound@...r.kernel.org, 
	lgirdwood@...il.com, vkoul@...nel.org, linux-crypto@...r.kernel.org, 
	tzimmermann@...e.de, atenart@...nel.org, krzk+dt@...nel.org, 
	linux-media@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH 30/38] arm64: dts: mediatek: pumpkin-common: Fix pinctrl
 node names

On Thu, Jul 24, 2025 at 5:50 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com> wrote:
>
> Fix the pinctrl node names to adhere to the bindings, as the main
> pin node is supposed to be named like "uart0-pins" and the pinmux
> node named like "pins-bus".
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Reviewed-by: Fei Shao <fshao@...omium.org>

> ---
>  .../boot/dts/mediatek/pumpkin-common.dtsi      | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> index a356db5fcc5f..805fb82138a8 100644
> --- a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> @@ -198,8 +198,8 @@ &usb_phy {
>  };
>
>  &pio {
> -       gpio_keys_default: gpiodefault {
> -               pins_cmd_dat {
> +       gpio_keys_default: gpio-keys-pins {
> +               pins-cmd-dat {
>                         pinmux = <MT8516_PIN_42_KPCOL0__FUNC_GPIO42>,
>                                  <MT8516_PIN_43_KPCOL1__FUNC_GPIO43>;
>                         bias-pull-up;
> @@ -207,7 +207,7 @@ pins_cmd_dat {
>                 };
>         };
>
> -       i2c0_pins_a: i2c0 {
> +       i2c0_pins_a: i2c0-pins {
>                 pins1 {
>                         pinmux = <MT8516_PIN_58_SDA0__FUNC_SDA0_0>,
>                                  <MT8516_PIN_59_SCL0__FUNC_SCL0_0>;
> @@ -215,7 +215,7 @@ pins1 {
>                 };
>         };
>
> -       i2c2_pins_a: i2c2 {
> +       i2c2_pins_a: i2c2-pins {
>                 pins1 {
>                         pinmux = <MT8516_PIN_60_SDA2__FUNC_SDA2_0>,
>                                  <MT8516_PIN_61_SCL2__FUNC_SCL2_0>;
> @@ -223,21 +223,21 @@ pins1 {
>                 };
>         };
>
> -       tca6416_pins: pinmux_tca6416_pins {
> -               gpio_mux_rst_n_pin {
> +       tca6416_pins: tca6416-pins {
> +               pins-mux-rstn {
>                         pinmux = <MT8516_PIN_65_UTXD1__FUNC_GPIO65>;
>                         output-high;
>                 };
>
> -               gpio_mux_int_n_pin {
> +               pins-mux-intn {
>                         pinmux = <MT8516_PIN_64_URXD1__FUNC_GPIO64>;
>                         input-enable;
>                         bias-pull-up;
>                 };
>         };
>
> -       ethernet_pins_default: ethernet {
> -               pins_ethernet {
> +       ethernet_pins_default: ethernet-pins {
> +               pins-eth {
>                         pinmux = <MT8516_PIN_0_EINT0__FUNC_EXT_TXD0>,
>                                  <MT8516_PIN_1_EINT1__FUNC_EXT_TXD1>,
>                                  <MT8516_PIN_5_EINT5__FUNC_EXT_RXER>,
> --
> 2.50.1
>
>