linux-kernel - Re: [PATCH v3] scsi: sd: fix sd shutdown to issue START STOP UNIT command appropriately

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <287c1b05-e271-47af-b373-36e329cf512e@kernel.org>
Date: Fri, 25 Jul 2025 19:49:36 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Salomon Dushimirimana <salomondush@...gle.com>
Cc: James.Bottomley@...senpartnership.com, bvanassche@....org,
 ipylypiv@...gle.com, linux-kernel@...r.kernel.org,
 linux-scsi@...r.kernel.org, martin.petersen@...cle.com, vishakhavc@...gle.com
Subject: Re: [PATCH v3] scsi: sd: fix sd shutdown to issue START STOP UNIT
 command appropriately

On 7/25/25 06:45, Salomon Dushimirimana wrote:
> Commit aa3998dbeb3a ("ata: libata-scsi: Disable scsi device
> manage_system_start_stop") enabled libata EH to manage device power mode
> trasitions for system suspend/resume and removed the flag from
> ata_scsi_dev_config. However, since the sd_shutdown() function still
> relies on the manage_system_start_stop flag, a spin-down command is not
> issued to the disk with command "echo 1 > /sys/block/sdb/device/delete"
> 
> sd_shutdown() can be called for both system/runtime start stop
> operations, so utilize the manage_run_time_start_stop flag set in the
> ata_scsi_dev_config and issue a spin-down command during disk removal
> when the system is running. This is in addition to when the system is
> powering off and manage_shutdown flag is set. The
> manage_system_start_stop flag will still be used for drivers that still
> set the flag.
> 
> Fixes: aa3998dbeb3a ("ata: libata-scsi: Disable scsi device manage_system_start_stop")
> Signed-off-by: Salomon Dushimirimana <salomondush@...gle.com>

Tested-by: Damien Le Moal <dlemoal@...nel.org>
Reviewed-by: Damien Le Moal <dlemoal@...nel.org>


-- 
Damien Le Moal
Western Digital Research