linux-kernel - Re: [PATCH v3 12/19] perf: stm32: introduce DDRPERFM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250725115908.000074d7@huawei.com>
Date: Fri, 25 Jul 2025 11:59:08 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Clément Le Goffic <clement.legoffic@...s.st.com>
CC: Will Deacon <will@...nel.org>, Mark Rutland <mark.rutland@....com>, "Rob
 Herring" <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Philipp Zabel
	<p.zabel@...gutronix.de>, Jonathan Corbet <corbet@....net>, Gatien Chevallier
	<gatien.chevallier@...s.st.com>, Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, "Gabriel Fernandez"
	<gabriel.fernandez@...s.st.com>, Krzysztof Kozlowski <krzk@...nel.org>, Le
 Goffic <legoffic.clement@...il.com>, Julius Werner <jwerner@...omium.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-perf-users@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>,
	<linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>,
	<linux-clk@...r.kernel.org>
Subject: Re: [PATCH v3 12/19] perf: stm32: introduce DDRPERFM driver

> > +
> > +	platform_set_drvdata(pdev, pmu);
> > +	pmu->dev = &pdev->dev;
> > +
> > +	pmu->cfg = device_get_match_data(pmu->dev);
> > +
> > +	pmu->membase = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> > +	if (IS_ERR(pmu->membase))
> > +		return PTR_ERR(pmu->membase);
> > +
> > +	if (of_property_present(pmu->dev->of_node, "access-controllers")) {
> > +		ret = stm32_firewall_get_firewall(pmu->dev->of_node, &firewall, 1);  
> 
> Jiri is busy driving dev_fwnode() thorugh to get rid of all the directly references
> to of_node.  Probably better to use that here from the start.
> 
Need more coffee. Ignore this one, you still need an of_node here.

> 
> > +		if (ret)
> > +			return dev_err_probe(pmu->dev, ret, "Failed to get firewall\n");
> > +		ret = stm32_firewall_grant_access_by_id(&firewall, firewall.firewall_id);
> > +		if (ret)
> > +			return dev_err_probe(pmu->dev, ret, "Failed to grant access\n");
> > +	}
> > +