[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202507251859.rtsTHw8u-lkp@intel.com>
Date: Fri, 25 Jul 2025 19:06:04 +0800
From: kernel test robot <lkp@...el.com>
To: Shengjiu Wang <shengjiu.wang@....com>, andrzej.hajda@...el.com,
neil.armstrong@...aro.org, rfoss@...nel.org,
Laurent.pinchart@...asonboard.com, jonas@...boo.se,
jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com,
mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com,
simona@...ll.ch, lumag@...nel.org, dianders@...omium.org,
cristian.ciocaltea@...labora.com, luca.ceresoli@...tlin.com,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
victor.liu@....com, shawnguo@...nel.org, s.hauer@...gutronix.de,
kernel@...gutronix.de, festevam@...il.com, imx@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, p.zabel@...gutronix.de,
devicetree@...r.kernel.org, l.stach@...gutronix.de
Cc: oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH v2 5/6] drm/bridge: imx: add driver for HDMI TX Parallel
Audio Interface
Hi Shengjiu,
kernel test robot noticed the following build errors:
[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on robh/for-next tiwai-sound/for-next tiwai-sound/for-linus linus/master v6.16-rc7 next-20250725]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shengjiu-Wang/dt-bindings-display-imx-add-HDMI-PAI-for-i-MX8MP/20250724-152710
base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link: https://lore.kernel.org/r/20250724072248.1517569-6-shengjiu.wang%40nxp.com
patch subject: [PATCH v2 5/6] drm/bridge: imx: add driver for HDMI TX Parallel Audio Interface
config: nios2-randconfig-002-20250725 (https://download.01.org/0day-ci/archive/20250725/202507251859.rtsTHw8u-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250725/202507251859.rtsTHw8u-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507251859.rtsTHw8u-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pai.c: In function 'imx8mp_hdmi_pai_enable':
>> drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pai.c:20:26: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
#define WTMK_HIGH(n) FIELD_PREP(WTMK_HIGH_MASK, (n))
^~~~~~~~~~
drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pai.c:53:9: note: in expansion of macro 'WTMK_HIGH'
val = WTMK_HIGH(3) | WTMK_LOW(3);
^~~~~~~~~
>> drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pai.c:59:9: error: implicit declaration of function 'FIELD_PREP_CONST'; did you mean 'FILE_REF_NOREF'? [-Werror=implicit-function-declaration]
val = FIELD_PREP_CONST(P_SEL,
^~~~~~~~~~~~~~~~
FILE_REF_NOREF
>> drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pai.c:60:12: error: implicit declaration of function '__bf_shf'; did you mean '__ffs64'? [-Werror=implicit-function-declaration]
__bf_shf(IEC958_SUBFRAME_PARITY));
^~~~~~~~
__ffs64
cc1: some warnings being treated as errors
vim +/FIELD_PREP +20 drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pai.c
15
16 #define HTX_PAI_CTRL_EXT 0x04
17 #define WTMK_HIGH_MASK GENMASK(31, 24)
18 #define WTMK_LOW_MASK GENMASK(23, 16)
19 #define NUM_CH_MASK GENMASK(10, 8)
> 20 #define WTMK_HIGH(n) FIELD_PREP(WTMK_HIGH_MASK, (n))
21 #define WTMK_LOW(n) FIELD_PREP(WTMK_LOW_MASK, (n))
22
23 #define HTX_PAI_FIELD_CTRL 0x08
24 #define B_FILT BIT(31)
25 #define PARITY_EN BIT(30)
26 #define END_SEL BIT(29)
27 #define PRE_SEL GENMASK(28, 24)
28 #define D_SEL GENMASK(23, 20)
29 #define V_SEL GENMASK(19, 15)
30 #define U_SEL GENMASK(14, 10)
31 #define C_SEL GENMASK(9, 5)
32 #define P_SEL GENMASK(4, 0)
33
34 #define HTX_PAI_STAT 0x0c
35 #define HTX_PAI_IRQ_NOMASK 0x10
36 #define HTX_PAI_IRQ_MASKED 0x14
37 #define HTX_PAI_IRQ_MASK 0x18
38
39 struct imx8mp_hdmi_pai {
40 struct device *dev;
41 struct regmap *regmap;
42 };
43
44 static void imx8mp_hdmi_pai_enable(struct dw_hdmi *dw_hdmi, int channel,
45 int width, int rate, int non_pcm,
46 int iec958)
47 {
48 const struct dw_hdmi_plat_data *pdata = dw_hdmi_to_plat_data(dw_hdmi);
49 struct imx8mp_hdmi_pai *hdmi_pai = (struct imx8mp_hdmi_pai *)pdata->priv_audio;
50 int val;
51
52 /* PAI set control extended */
53 val = WTMK_HIGH(3) | WTMK_LOW(3);
54 val |= FIELD_PREP(NUM_CH_MASK, channel - 1);
55 regmap_write(hdmi_pai->regmap, HTX_PAI_CTRL_EXT, val);
56
57 /* IEC60958 format */
58 if (iec958) {
> 59 val = FIELD_PREP_CONST(P_SEL,
> 60 __bf_shf(IEC958_SUBFRAME_PARITY));
61 val |= FIELD_PREP_CONST(C_SEL,
62 __bf_shf(IEC958_SUBFRAME_CHANNEL_STATUS));
63 val |= FIELD_PREP_CONST(U_SEL,
64 __bf_shf(IEC958_SUBFRAME_USER_DATA));
65 val |= FIELD_PREP_CONST(V_SEL,
66 __bf_shf(IEC958_SUBFRAME_VALIDITY));
67 val |= FIELD_PREP_CONST(D_SEL,
68 __bf_shf(IEC958_SUBFRAME_SAMPLE_24_MASK));
69 val |= FIELD_PREP_CONST(PRE_SEL,
70 __bf_shf(IEC958_SUBFRAME_PREAMBLE_MASK));
71 } else {
72 /* PCM choose 24bit*/
73 val = FIELD_PREP(D_SEL, width - 24);
74 }
75
76 regmap_write(hdmi_pai->regmap, HTX_PAI_FIELD_CTRL, val);
77
78 /* PAI start running */
79 regmap_write(hdmi_pai->regmap, HTX_PAI_CTRL, ENABLE);
80 }
81
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists