linux-kernel - Re: [PATCH v6 0/7] rust/hrtimer: Various hrtimer + time additions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <71C2DE74-1BB7-4AC0-83BD-2CC8B871B078@collabora.com>
Date: Fri, 25 Jul 2025 11:11:09 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Lyude Paul <lyude@...hat.com>
Cc: rust-for-linux@...r.kernel.org,
 Thomas Gleixner <tglx@...utronix.de>,
 Boqun Feng <boqun.feng@...il.com>,
 linux-kernel@...r.kernel.org,
 Andreas Hindborg <a.hindborg@...nel.org>,
 FUJITA Tomonori <fujita.tomonori@...il.com>,
 Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH v6 0/7] rust/hrtimer: Various hrtimer + time additions

Hi Lyude,

> On 24 Jul 2025, at 15:49, Lyude Paul <lyude@...hat.com> wrote:
> 
> This is a collection of various bindings that I added to hrtimer when I
> was originally getting it ready to be used in rvkms. I've mostly been
> waiting for Andreas's hrtimer series to go upstream before submitting
> these.
> 
> All of these are currently being used within rvkms for vblank emulation.
> 
> Previous versions:
>  Version 1: https://lkml.org/lkml/2025/4/2/1474
>  Version 2: https://lkml.org/lkml/2025/4/15/1750
>  Version 3 (only a revision of one patch): https://lkml.org/lkml/2025/4/15/1780
>  Version 4: https://lkml.org/lkml/2025/4/29/1715
>  Version 5: https://lkml.org/lkml/2025/6/13/1785
> 
> Usage example:
> (keep in mind, I haven't rebased the example entirely - but the only
>  differences there is a few comments)
> 
>  https://gitlab.freedesktop.org/lyudess/linux/-/tree/rvkms-slim/rust/kernel?ref_type=heads
> 
> Lyude Paul (7):
>  rust: hrtimer: Document the return value for HrTimerHandle::cancel()
>  rust: hrtimer: Add HrTimerInstant
>  rust: hrtimer: Add HrTimer::raw_forward() and forward()
>  rust: hrtimer: Add HrTimerCallbackContext and ::forward()
>  rust: hrtimer: Add forward_now() to HrTimer and HrTimerCallbackContext
>  rust: time: Add Instant::from_nanos()
>  rust: hrtimer: Add HrTimer::expires()
> 
> rust/kernel/time.rs                 |  22 ++++
> rust/kernel/time/hrtimer.rs         | 152 +++++++++++++++++++++++++++-
> rust/kernel/time/hrtimer/arc.rs     |   9 +-
> rust/kernel/time/hrtimer/pin.rs     |   9 +-
> rust/kernel/time/hrtimer/pin_mut.rs |  12 ++-
> rust/kernel/time/hrtimer/tbox.rs    |   9 +-
> 6 files changed, 204 insertions(+), 9 deletions(-)
> 
> 
> base-commit: dff64b072708ffef23c117fa1ee1ea59eb417807
> -- 
> 2.50.0
> 
> 


Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>

A few very minor nits will follow.

— Daniel