linux-kernel - Re: [PATCH -next] platform/x86: hfi: Remove unnecessary .owner for amd_hfi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb4d48ae-c1a0-4e12-a367-ba8217599e59@amd.com>
Date: Fri, 25 Jul 2025 10:30:51 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
 Borislav Petkov <bp@...en8.de>
Cc: perry.yuan@....com, hansg@...nel.org, ilpo.jarvinen@...ux.intel.com,
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
 Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] platform/x86: hfi: Remove unnecessary .owner for
 amd_hfi_driver

+Boris for this to go through tip.

On 7/25/2025 3:27 AM, Jiapeng Chong wrote:
> Remove .owner field if calls are used which set it automatically.
> 
> ./drivers/platform/x86/amd/hfi/hfi.c:512:3-8: No need to set .owner here. The core will do it.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=22940
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

> ---
>   drivers/platform/x86/amd/hfi/hfi.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/amd/hfi/hfi.c b/drivers/platform/x86/amd/hfi/hfi.c
> index 4f56149b3774..b633363ebf70 100644
> --- a/drivers/platform/x86/amd/hfi/hfi.c
> +++ b/drivers/platform/x86/amd/hfi/hfi.c
> @@ -509,7 +509,6 @@ static int amd_hfi_probe(struct platform_device *pdev)
>   static struct platform_driver amd_hfi_driver = {
>   	.driver = {
>   		.name = AMD_HFI_DRIVER,
> -		.owner = THIS_MODULE,
>   		.pm = &amd_hfi_pm_ops,
>   		.acpi_match_table = ACPI_PTR(amd_hfi_platform_match),
>   	},