linux-kernel - Re: [PATCH] usb: gadget: Add gadgetmon traffic monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025072527-entrust-childless-3ae9@gregkh>
Date: Fri, 25 Jul 2025 17:33:23 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Olivier Tuchon <tcn@...gle.com>
Cc: linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: Add gadgetmon traffic monitor

Cool, but:

On Fri, Jul 25, 2025 at 05:25:49PM +0200, Olivier Tuchon wrote:
> Signed-off-by: Oliv <tcn@...gle.com>

Doesn't match the From: line :(

> +config GADGETMON_BUFFER_SIZE_MB
> + int "Buffer size for gadget monitor (in MiB)"
> + depends on USB_GADGET_MON
> + default 4
> + help
> +   Sets the size of the ring buffer used to transfer event data
> +   from the kernel to userspace. A larger buffer reduces the risk
> +   of dropping events during high-speed traffic bursts but uses
> +   more kernel memory. Value is in Megabytes (MiB).

<snip>

Patch is totally corrupted with whitespace issues everywhere, making it
impossible to apply or even review :(

thanks,

greg k-h