linux-kernel - Re: [PATCH 2/3] blk-wbt: Eliminate ambiguity in the comments of struct rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <r5qjezoetjiuw6vyjvya6o7boikidjp36hzywpgqu4nfwy4jw4@dlbauxv4mmq6>
Date: Fri, 25 Jul 2025 17:41:28 +0200
From: Jan Kara <jack@...e.cz>
To: Tang Yizhou <yizhou.tang@...pee.com>
Cc: axboe@...nel.dk, hch@....de, jack@...e.cz, linux-block@...r.kernel.org, 
	linux-kernel@...r.kernel.org, tangyeechou@...il.com
Subject: Re: [PATCH 2/3] blk-wbt: Eliminate ambiguity in the comments of
 struct rq_wb

On Thu 24-07-25 16:30:00, Tang Yizhou wrote:
> From: Tang Yizhou <yizhou.tang@...pee.com>
> 
> In the current implementation, the last_issue and last_comp members of
> struct rq_wb are used only by read requests and not by non-throttled write
> requests. Therefore, eliminate the ambiguity here.
> 
> Signed-off-by: Tang Yizhou <yizhou.tang@...pee.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  block/blk-wbt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/blk-wbt.c b/block/blk-wbt.c
> index 30886d44f6cd..eb8037bae0bd 100644
> --- a/block/blk-wbt.c
> +++ b/block/blk-wbt.c
> @@ -85,8 +85,8 @@ struct rq_wb {
>  	u64 sync_issue;
>  	void *sync_cookie;
>  
> -	unsigned long last_issue;		/* last non-throttled issue */
> -	unsigned long last_comp;		/* last non-throttled comp */
> +	unsigned long last_issue;	/* issue time of last read rq */
> +	unsigned long last_comp;	/* completion time of last read rq */
>  	unsigned long min_lat_nsec;
>  	struct rq_qos rqos;
>  	struct rq_wait rq_wait[WBT_NUM_RWQ];
> -- 
> 2.25.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR