linux-kernel - Re: [PATCH v2 05/19] gpu: nova-core: register: simplify @leaf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <505C79FD-3C42-4544-ABCC-E03F4170A2A8@collabora.com>
Date: Fri, 25 Jul 2025 13:53:00 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Alexandre Courbot <acourbot@...dia.com>
Cc: Danilo Krummrich <dakr@...nel.org>,
 David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>,
 Beata Michalska <beata.michalska@....com>,
 nouveau@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org,
 rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/19] gpu: nova-core: register: simplify
 @leaf_accessor rule



> On 18 Jul 2025, at 04:26, Alexandre Courbot <acourbot@...dia.com> wrote:
> 
> The `$type` metavariable is not used in the @leaf_accessor rule, so
> remove it.
> 
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> ---
> drivers/gpu/nova-core/regs/macros.rs | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/nova-core/regs/macros.rs b/drivers/gpu/nova-core/regs/macros.rs
> index dac02f8055e76da68e9a82133fa09a1e794252bc..37c7c454ba810447e1fe41231650e616e2f86eb8 100644
> --- a/drivers/gpu/nova-core/regs/macros.rs
> +++ b/drivers/gpu/nova-core/regs/macros.rs
> @@ -230,7 +230,7 @@ impl $name {
>             $(, $comment:literal)?;
>     ) => {
>         register!(
> -            @leaf_accessor $name $hi:$lo $field as bool
> +            @leaf_accessor $name $hi:$lo $field
>             { |f| <$into_type>::from(if f != 0 { true } else { false }) }
>             $into_type => $into_type $(, $comment)?;
>         );
> @@ -248,7 +248,7 @@ impl $name {
>         @field_accessor $name:ident $hi:tt:$lo:tt $field:ident as $type:tt ?=> $try_into_type:ty
>             $(, $comment:literal)?;
>     ) => {
> -        register!(@leaf_accessor $name $hi:$lo $field as $type
> +        register!(@leaf_accessor $name $hi:$lo $field
>             { |f| <$try_into_type>::try_from(f as $type) } $try_into_type =>
>             ::core::result::Result<
>                 $try_into_type,
> @@ -262,7 +262,7 @@ impl $name {
>         @field_accessor $name:ident $hi:tt:$lo:tt $field:ident as $type:tt => $into_type:ty
>             $(, $comment:literal)?;
>     ) => {
> -        register!(@leaf_accessor $name $hi:$lo $field as $type
> +        register!(@leaf_accessor $name $hi:$lo $field
>             { |f| <$into_type>::from(f as $type) } $into_type => $into_type $(, $comment)?;);
>     };
> 
> @@ -276,7 +276,7 @@ impl $name {
> 
>     // Generates the accessor methods for a single field.
>     (
> -        @leaf_accessor $name:ident $hi:tt:$lo:tt $field:ident as $type:ty
> +        @leaf_accessor $name:ident $hi:tt:$lo:tt $field:ident
>             { $process:expr } $to_type:ty => $res_type:ty $(, $comment:literal)?;
>     ) => {
>         ::kernel::macros::paste!(
> 
> -- 
> 2.50.1
> 
> 

Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>