linux-kernel - Re: [PATCH v6 1/8] mmc: sdhci-of-dwcmshc: add common bulk optional clocks support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DBLARE9EUGTB.1AIKSIZBIXHIJ@cknow.org>
Date: Fri, 25 Jul 2025 19:03:29 +0200
From: "Diederik de Haas" <didi.debian@...ow.org>
To: "Adrian Hunter" <adrian.hunter@...el.com>, "Robin Murphy"
 <robin.murphy@....com>, "Chen Wang" <unicornxw@...il.com>,
 <aou@...s.berkeley.edu>, <conor+dt@...nel.org>, <guoren@...nel.org>,
 <inochiama@...look.com>, <jszhang@...nel.org>,
 <krzysztof.kozlowski+dt@...aro.org>, <palmer@...belt.com>,
 <paul.walmsley@...ive.com>, <robh@...nel.org>, <ulf.hansson@...aro.org>,
 <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-mmc@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
 <chao.wei@...hgo.com>, <haijiao.liu@...hgo.com>,
 <xiaoguang.xing@...hgo.com>, <tingzhu.wang@...hgo.com>
Cc: "Chen Wang" <unicorn_wang@...look.com>, "Drew Fustini" <drew@...7.com>,
 <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH v6 1/8] mmc: sdhci-of-dwcmshc: add common bulk optional
 clocks support

On Thu Jul 24, 2025 at 4:57 PM CEST, Adrian Hunter wrote:
> On 24/07/2025 17:33, Diederik de Haas wrote:
>> On Wed Jul 23, 2025 at 7:33 AM CEST, Adrian Hunter wrote:
>>> On 22/07/2025 21:33, Robin Murphy wrote:
>>>> A bit late for a "review", but Diederik and I have just been
>>>> IRC-debugging a crash on RK3568 which by inspection seems to be caused
>>>> by this patch:
>>>>
>>>> On 2024-08-05 10:17 am, Chen Wang wrote:
>>>>> From: Chen Wang <unicorn_wang@...look.com>
>>>>>
>>>>> In addition to the required core clock and optional
>>>>> bus clock, the soc will expand its own clocks, so
>>>>> the bulk clock mechanism is abstracted.
>>>>>
>>>>> Note, I call the bulk clocks as "other clocks" due
>>>>> to the bus clock has been called as "optional".
>>>>>
>>>>> Signed-off-by: Chen Wang <unicorn_wang@...look.com>
>>>>> Tested-by: Drew Fustini <drew@...7.com> # TH1520
>>>>> Tested-by: Inochi Amaoto <inochiama@...look.com> # Duo and Huashan Pi
>>>>> ---
>>>
>>> Presumably the problem has gone away with:
>>>
>>> 	commit 91a001a1a0749e5d24606d46ac5dfd4433c00956
>>> 	Author: Binbin Zhou <zhoubinbin@...ngson.cn>
>>> 	Date:   Sat Jun 7 15:39:01 2025 +0800
>>>
>>> 	    mmc: sdhci-of-dwcmshc: Drop the use of sdhci_pltfm_free()
>>>
>>> which is in next.
>>>
>>> In which case a separate fix is needed for stable.
>> 
>> Adding that patch to my 6.16-rc7 kernel indeed stopped the OOPSies.
>> Thanks!
>
> You need the other patches that it depends on, otherwise you are
> just leaking the memory.  Refer:
>
> 	https://lore.kernel.org/all/cover.1749127796.git.zhoubinbin@loongson.cn/

Also with the other patches, the OOPSies stopped :-)

Cheers,
  Diederik

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)