linux-kernel - Re: [PATCH] block: change blk_get_meta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <2b0865be-c198-434c-bc06-e11a53e7a0cc@app.fastmail.com>
Date: Fri, 25 Jul 2025 19:45:25 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Klara Modin" <klarasmodin@...il.com>,
 "Christian Brauner" <brauner@...nel.org>,
 "Anuj Gupta" <anuj20.g@...sung.com>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Martin K. Petersen" <martin.petersen@...cle.com>,
 "Kanchan Joshi" <joshi.k@...sung.com>,
 "Christoph Hellwig" <hch@...radead.org>,
 "Naresh Kamboju" <naresh.kamboju@...aro.org>,
 "Anders Roxell" <anders.roxell@...aro.org>, "Jens Axboe" <axboe@...nel.dk>,
 "Keith Busch" <kbusch@...nel.org>,
 "Caleb Sander Mateos" <csander@...estorage.com>,
 "Pavel Begunkov" <asml.silence@...il.com>,
 "Alexey Dobriyan" <adobriyan@...il.com>,
 "Darrick J. Wong" <djwong@...nel.org>, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: change blk_get_meta_cap() stub return -ENOIOCTLCMD

On Fri, Jul 25, 2025, at 18:43, Klara Modin wrote:
> When introduced in commit 9eb22f7fedfc ("fs: add ioctl to query metadata
> and protection info capabilities") the stub of blk_get_meta_cap() for
> !BLK_DEV_INTEGRITY always returns -EOPNOTSUPP. The motivation was that
> while the command was unsupported in that configuration it was still
> recognized.
>
> A later change instead assumed -ENOIOCTLCMD as is required for unknown
> ioctl commands per Documentation/driver-api/ioctl.rst. The result being
> that on !BLK_DEV_INTEGRITY configs, any ioctl which reaches
> blkdev_common_ioctl() will return -EOPNOTSUPP.
>
> Change the stub to return -ENOIOCTLCMD, fixing the issue and better
> matching with expectations.
>
> Link: 
> https://lore.kernel.org/lkml/CACzX3AsRd__fXb9=CJPTTJC494SDnYAtYrN2=+bZgMCvM6UQDg@mail.gmail.com
> Fixes: 42b0ef01e6b5 ("block: fix FS_IOC_GETLBMD_CAP parsing in 
> blkdev_common_ioctl()")
> Signed-off-by: Klara Modin <klarasmodin@...il.com>

Reviewed-by: Arnd Bergmann <arnd@...db.de>

Thanks for the fix!