linux-kernel - Re: [PATCH v2] usb: gadget: Address review comments and include missing files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025072652-chewable-stupor-9a4d@gregkh>
Date: Sat, 26 Jul 2025 08:39:51 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Olivier Tuchon <tcn@...gle.com>
Cc: Alan Stern <stern@...land.harvard.edu>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: gadget: Address review comments and include
 missing files

On Fri, Jul 25, 2025 at 11:09:26PM +0200, Olivier Tuchon wrote:
> This patch addresses feedback on v1 from greg k-h and Alan Stern. It
> also includes files that were missing from the initial submission.
> 
> The following changes have been made:
>   - correct initial coding style issue (spaces for tabs)
>   - add missing file required for the feature to build and run
>   - improve FIFO full handling by truncating event data instead of
>     dropping the event entirely
>   - avoid capturing redundant data for IN submissions

This is not a proper way to write a subject line or comments at all.

Look at patches on the list and in the tree, nothing starts with
"address review comments", right?

Please go back and start again...


> 
> Signed-off-by: Olivier Tuchon <tcn@...gle.com>
> ---
>  drivers/usb/Kconfig                     |  2 +
>  drivers/usb/Makefile                    |  1 +
>  drivers/usb/gadget/udc/core.c           | 78 +++++++++++++++++++++++++
>  drivers/usb/gadget_mon/Kconfig          | 20 +++----
>  drivers/usb/gadget_mon/gadgetmon_main.c | 41 ++++++++-----
>  include/linux/usb/gadget.h              | 23 ++++++++
>  6 files changed, 141 insertions(+), 24 deletions(-)

Please read the in-kernel documentation about how to submit a kernel
patch, it should explain all of this, right?  If not, please work with
someone in your group that knows how to create kernel patches, don't
require the community to do that kind of basic review/training for you.

thanks,

greg k-h