linux-kernel - Re: [PATCH net] phy: dp83869: fix interrupts issue when using with an optical fiber sfp. to correctly clear the interrupts both status registers must be read.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250725171446.73bb3f8c@kernel.org>
Date: Fri, 25 Jul 2025 17:14:46 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: chalianis1@...il.com
Cc: andrew@...n.ch, hkallweit1@...il.com, edumazet@...gle.com,
 pabeni@...hat.com, linux@...linux.org.uk, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net] phy: dp83869: fix interrupts issue when using with
 an optical fiber sfp. to correctly clear the interrupts both status
 registers must be read.

First of all, please read:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html

> Subject: [PATCH net] phy: dp83869: fix interrupts issue when using with an optical fiber sfp. to correctly clear the interrupts both status registers must be read.

The first line of the commit message becomes the subject, it should
be a very short summary of the patch (100 chars max)

On Fri, 25 Jul 2025 20:10:34 -0400 chalianis1@...il.com wrote:
> From: Anis Chali <chalianis1@...il.com>
> 
> from datasheet of dp83869hm
> 7.3.6 Interrupt
> The DP83869HM can be configured to generate an interrupt when changes of internal status occur. The interrupt
> allows a MAC to act upon the status in the PHY without polling the PHY registers. The interrupt source can be
> selected through the interrupt registers, MICR (12h) and FIBER_INT_EN (C18h). The interrupt status can be
> read from ISR (13h) and FIBER_INT_STTS (C19h) registers. Some interrupts are enabled by default and can
> be disabled through register access. Both the interrupt status registers must be read in order to clear pending
> interrupts. Until the pending interrupts are cleared, new interrupts may not be routed to the interrupt pin.

This needs to be line wrapped at 70-ish characters.

> Fixes: 01db923e8377 ("net: phy: dp83869: Add TI dp83869 phy")
> 

no empty lines between tags, please

> Cc: stable@...r.kernel.org
> Signed-off-by: Anis Chali <chalianis1@...il.com>
-- 
pw-bot: cr