linux-kernel - Re: [PATCH v3] kheaders: make it possible to override TAR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATRPWXZ5WT2C8Q1DL=1+ocUK3RFEyUneUvhcjk3WCv1SQ@mail.gmail.com>
Date: Sat, 26 Jul 2025 15:46:52 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Michał Górny <mgorny@...too.org>
Cc: Nathan Chancellor <nathan@...nel.org>, Sam James <sam@...too.org>, 
	Nicolas Schier <nicolas.schier@...ux.dev>, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] kheaders: make it possible to override TAR

On Mon, Jul 21, 2025 at 4:08 AM Michał Górny <mgorny@...too.org> wrote:
>
> On Sat, 2025-07-19 at 16:10 -0400, Nathan Chancellor wrote:
> > On Sat, Jul 19, 2025 at 04:24:05PM +0100, Sam James wrote:
> > > From: Michał Górny <mgorny@...too.org>
> > >
> > > Commit 86cdd2fdc4e39c388d39c7ba2396d1a9dfd66226 ("kheaders: make headers
> > > archive reproducible") introduced a number of options specific to GNU
> > > tar to the `tar` invocation in `gen_kheaders.sh` script.  This causes
> > > the script to fail to work on systems where `tar` is not GNU tar.  This
> > > can occur e.g. on recent Gentoo Linux installations that support using
> > > bsdtar from libarchive instead.
> > >
> > > Add a `TAR` make variable to make it possible to override the tar
> > > executable used, e.g. by specifying:
> > >
> > >   make TAR=gtar
> > >
> > > Link: https://bugs.gentoo.org/884061
> > > Reported-by: Sam James <sam@...too.org>
> > > Tested-by: Sam James <sam@...too.org>
> > > Co-developed-by: Masahiro Yamada <masahiroy@...nel.org>
> > > Signed-off-by: Michał Górny <mgorny@...too.org>
> > > Signed-off-by: Sam James <sam@...too.org>
> > > ---
> >
> > Reviewed-by: Nathan Chancellor <nathan@...nel.org>
> >
> > I assume that other places that call tar within the build process are
> > not problematic because they do not use GNU specific options, such as
> > scripts/Makefile.package and scripts/package/install-extmod-build, or
> > maybe that people just have not tried building those packages with
> > bsdtar?
>
> Precisely.  We focused on the one place which actually breaks our build,
> to avoid touching too many subsystems simultaneously.  If this is
> desirable, I can look into replacing the other instances.
>

This patch is not applicable to my tree.

Please rebase to the kbuild tree (or linux-next).




-- 
Best Regards
Masahiro Yamada