linux-kernel - Re: [PATCH 1/4] platform/x86: (ayn-ec) Add PWM Fan HWMON Interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507261841.lk1Z3fqj-lkp@intel.com>
Date: Sat, 26 Jul 2025 18:57:32 +0800
From: kernel test robot <lkp@...el.com>
To: "Derek J. Clark" <derekjohn.clark@...il.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Hans de Goede <hansg@...nel.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>,
	"Derek J . Clark" <derekjohn.clark@...il.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-hwmon@...r.kernel.org
Subject: Re: [PATCH 1/4] platform/x86: (ayn-ec) Add PWM Fan HWMON Interface

Hi Derek,

kernel test robot noticed the following build warnings:

[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on linus/master v6.16-rc7 next-20250725]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Derek-J-Clark/platform-x86-ayn-ec-Add-Temperature-Sensors/20250725-084850
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link:    https://lore.kernel.org/r/20250725004533.63537-1-derekjohn.clark%40gmail.com
patch subject: [PATCH 1/4] platform/x86: (ayn-ec) Add PWM Fan HWMON Interface
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20250726/202507261841.lk1Z3fqj-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250726/202507261841.lk1Z3fqj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507261841.lk1Z3fqj-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/platform/x86/ayn-ec.c:526:6: warning: unused variable 'ret' [-Wunused-variable]
     526 |         int ret;
         |             ^~~
>> drivers/platform/x86/ayn-ec.c:557:35: warning: unused variable 'ayn_dmi_table' [-Wunused-const-variable]
     557 | static const struct dmi_system_id ayn_dmi_table[] = {
         |                                   ^~~~~~~~~~~~~
   2 warnings generated.


vim +/ayn_dmi_table +557 drivers/platform/x86/ayn-ec.c

   521	
   522	static int ayn_ec_probe(struct platform_device *pdev)
   523	{
   524		struct device *dev = &pdev->dev;
   525		struct device *hwdev;
 > 526		int ret;
   527	
   528		hwdev = devm_hwmon_device_register_with_info(dev, "aynec", NULL,
   529							     &ayn_ec_chip_info,
   530							     ayn_sensors_groups);
   531		return PTR_ERR_OR_ZERO(hwdev);
   532	}
   533	
   534	static struct platform_driver ayn_ec_driver = {
   535		.driver = {
   536			.name = "ayn-ec",
   537		},
   538		.probe = ayn_ec_probe,
   539	};
   540	
   541	static struct platform_device *ayn_ec_device;
   542	
   543	static int __init ayn_ec_init(void)
   544	{
   545		ayn_ec_device = platform_create_bundle(&ayn_ec_driver, ayn_ec_probe,
   546						       NULL, 0, NULL, 0);
   547	
   548		return PTR_ERR_OR_ZERO(ayn_ec_device);
   549	}
   550	
   551	static void __exit ayn_ec_exit(void)
   552	{
   553		platform_device_unregister(ayn_ec_device);
   554		platform_driver_unregister(&ayn_ec_driver);
   555	}
   556	
 > 557	static const struct dmi_system_id ayn_dmi_table[] = {
   558		{
   559			.matches = {
   560				DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "ayn"),
   561				DMI_EXACT_MATCH(DMI_BOARD_NAME, "Loki Max"),
   562			},
   563			.driver_data = (void *)ayn_loki_max,
   564		},
   565		{
   566			.matches = {
   567				DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "ayn"),
   568				DMI_EXACT_MATCH(DMI_BOARD_NAME, "Loki MiniPro"),
   569			},
   570			.driver_data = (void *)ayn_loki_minipro,
   571		},
   572		{
   573			.matches = {
   574				DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "ayn"),
   575				DMI_EXACT_MATCH(DMI_BOARD_NAME, "Loki Zero"),
   576			},
   577			.driver_data = (void *)ayn_loki_zero,
   578		},
   579		{
   580			.matches = {
   581				DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Tectoy"),
   582				DMI_EXACT_MATCH(DMI_BOARD_NAME, "Zeenix Lite"),
   583			},
   584			.driver_data = (void *)tactoy_zeenix_lite,
   585		},
   586		{},
   587	};
   588	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki