linux-kernel - Re: [PATCH 1/4] platform/x86: (ayn-ec) Add PWM Fan HWMON Interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507261928.2I5G2r8J-lkp@intel.com>
Date: Sat, 26 Jul 2025 20:06:10 +0800
From: kernel test robot <lkp@...el.com>
To: "Derek J. Clark" <derekjohn.clark@...il.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Hans de Goede <hansg@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>,
	"Derek J . Clark" <derekjohn.clark@...il.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-hwmon@...r.kernel.org
Subject: Re: [PATCH 1/4] platform/x86: (ayn-ec) Add PWM Fan HWMON Interface

Hi Derek,

kernel test robot noticed the following build errors:

[auto build test ERROR on groeck-staging/hwmon-next]
[also build test ERROR on linus/master v6.16-rc7 next-20250725]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Derek-J-Clark/platform-x86-ayn-ec-Add-Temperature-Sensors/20250725-084850
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link:    https://lore.kernel.org/r/20250725004533.63537-1-derekjohn.clark%40gmail.com
patch subject: [PATCH 1/4] platform/x86: (ayn-ec) Add PWM Fan HWMON Interface
config: i386-randconfig-007-20250726 (https://download.01.org/0day-ci/archive/20250726/202507261928.2I5G2r8J-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250726/202507261928.2I5G2r8J-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507261928.2I5G2r8J-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/platform/x86/ayn-ec.o: in function `read_from_ec':
>> drivers/platform/x86/ayn-ec.c:99: undefined reference to `ec_read'
   ld: drivers/platform/x86/ayn-ec.o: in function `write_to_ec':
>> drivers/platform/x86/ayn-ec.c:128: undefined reference to `ec_write'


vim +99 drivers/platform/x86/ayn-ec.c

    79	
    80	/**
    81	 * read_from_ec() - Reads a value from the embedded controller.
    82	 *
    83	 * @reg: The register to start the read from.
    84	 * @size: The number of sequential registers the data is contained in.
    85	 * @val: Pointer to return the data with.
    86	 *
    87	 * Return: 0, or an error.
    88	 */
    89	static int read_from_ec(u8 reg, int size, long *val)
    90	{
    91		int ret, i;
    92		u8 buf;
    93	
    94		if (!lock_global_acpi_lock())
    95			return -EBUSY;
    96	
    97		*val = 0;
    98		for (i = 0; i < size; i++) {
  > 99			ret = ec_read(reg + i, &buf);
   100			if (ret)
   101				return ret;
   102			*val <<= i * 8;
   103			*val += buf;
   104		}
   105	
   106		if (!unlock_global_acpi_lock())
   107			return -EBUSY;
   108	
   109		return 0;
   110	}
   111	
   112	/**
   113	 * write_to_ec() - Writes a value to the embedded controller.
   114	 *
   115	 * @reg: The register to write to.
   116	 * @val: Value to write
   117	 *
   118	 * Return: 0, or an error.
   119	 */
   120	static int write_to_ec(u8 reg, u8 val)
   121	{
   122		int ret;
   123	
   124		if (!lock_global_acpi_lock())
   125			return -EBUSY;
   126	
   127		pr_info("Writing EC value %d to register %u\n", val, reg);
 > 128		ret = ec_write(reg, val);
   129	
   130		if (!unlock_global_acpi_lock())
   131			return -EBUSY;
   132	
   133		return ret;
   134	}
   135	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki