linux-kernel - Re: [PATCH 1/7] arm64: dts: qcom: Rename sa8775p SoC to "lemans"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vc2z57myldazay75qwbxotxr5siooqny2vviu6yznna3fdj3ed@6fpcy7dcg6t3>
Date: Sat, 26 Jul 2025 12:11:58 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
	Wasim Nazir <wasim.nazir@....qualcomm.com>, Konrad Dybcio <konradybcio@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Richard Cochran <richardcochran@...il.com>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org, kernel@....qualcomm.com
Subject: Re: [PATCH 1/7] arm64: dts: qcom: Rename sa8775p SoC to "lemans"

On Thu, Jul 24, 2025 at 02:51:54PM +0200, Krzysztof Kozlowski wrote:
> On 24/07/2025 14:47, Konrad Dybcio wrote:
> > On 7/23/25 10:29 AM, 'Krzysztof Kozlowski' via kernel wrote:
> >> On Tue, Jul 22, 2025 at 08:19:20PM +0530, Wasim Nazir wrote:
> >>> SA8775P, QCS9100 and QCS9075 are all variants of the same die,
> >>> collectively referred to as lemans. Most notably, the last of them
> >>> has the SAIL (Safety Island) fused off, but remains identical
> >>> otherwise.
> >>>
> >>> In an effort to streamline the codebase, rename the SoC DTSI, moving
> >>> away from less meaningful numerical model identifiers.
> >>>
> >>> Signed-off-by: Wasim Nazir <wasim.nazir@....qualcomm.com>
> >>> ---
> >>>  arch/arm64/boot/dts/qcom/{sa8775p.dtsi => lemans.dtsi} | 0
> >>>  arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi             | 2 +-
> >>
> >> No, stop with this rename.
> >>
> >> There is no policy of renaming existing files.
> > 
> > There's no policy against renaming existing files either.
> 
> There is, because you break all the users. All the distros, bootloaders
> using this DTS, people's scripts.
> 

None of these users are affected by the rename of the .dtsi file.

Patch 5 does have user impact, so that one would be "controversial".
>From the answers I've gotten, I'm questioning which of thees files
actually has users - but that's best done in a standalone patch removing
or renaming them, with a proper commit message.

> > 
> >> It's ridicilous. Just
> >> because you introduced a new naming model for NEW SOC, does not mean you
> >> now going to rename all boards which you already upstreamed.
> > 
> > This is a genuine improvement, trying to untangle the mess that you
> > expressed vast discontent about..
> > 
> > There will be new boards based on this family of SoCs submitted either
> > way, so I really think it makes sense to solve it once and for all,
> > instead of bikeshedding over it again and again each time you get a new
> > dt-bindings change in your inbox.
> > 
> > I understand you're unhappy about patch 6, but the others are
> > basically code janitoring.
> 
> Renaming already accepted DTS is not improvement and not untangling
> anything.

No, but the rename of the dtsi file and avoiding introducing yet another
qcs<random numbers> prefix in the soup is a huge improvement.

> These names were discussed (for very long time) and agreed on.
> What is the point of spending DT maintainers time to discuss the sa8775p
> earlier when year later you come and start reversing things (like in
> patch 6).
> 

There was no point, all the information wasn't brought to those
discussions...

What we know now is that QCS9100 and QCS9075 (and perhaps more?) are the
Lemans IoT product line and the EVK is the main development board
there on.

It's unclear if there are any lingering users of sa8775p-ride, but
the platform we describe in sa8775p.dtsi doesn't exist anymore. To the
best of my understanding, any users of the ride hardware should be on
qcs9100-ride...

Regards,
Bjorn