linux-kernel - Re: [PATCH 1/7] arm64: dts: qcom: Rename sa8775p SoC to "lemans"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250726180451.GM1367887@horms.kernel.org>
Date: Sat, 26 Jul 2025 19:04:51 +0100
From: Simon Horman <horms@...nel.org>
To: Rob Clark <rob.clark@....qualcomm.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
	Wasim Nazir <wasim.nazir@....qualcomm.com>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Richard Cochran <richardcochran@...il.com>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	kernel@....qualcomm.com
Subject: Re: [PATCH 1/7] arm64: dts: qcom: Rename sa8775p SoC to "lemans"

On Thu, Jul 24, 2025 at 08:59:38AM -0700, Rob Clark wrote:
> On Thu, Jul 24, 2025 at 5:52 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >
> > On 24/07/2025 14:47, Konrad Dybcio wrote:
> > > On 7/23/25 10:29 AM, 'Krzysztof Kozlowski' via kernel wrote:
> > >> On Tue, Jul 22, 2025 at 08:19:20PM +0530, Wasim Nazir wrote:
> > >>> SA8775P, QCS9100 and QCS9075 are all variants of the same die,
> > >>> collectively referred to as lemans. Most notably, the last of them
> > >>> has the SAIL (Safety Island) fused off, but remains identical
> > >>> otherwise.
> > >>>
> > >>> In an effort to streamline the codebase, rename the SoC DTSI, moving
> > >>> away from less meaningful numerical model identifiers.
> > >>>
> > >>> Signed-off-by: Wasim Nazir <wasim.nazir@....qualcomm.com>
> > >>> ---
> > >>>  arch/arm64/boot/dts/qcom/{sa8775p.dtsi => lemans.dtsi} | 0
> > >>>  arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi             | 2 +-
> > >>
> > >> No, stop with this rename.
> > >>
> > >> There is no policy of renaming existing files.
> > >
> > > There's no policy against renaming existing files either.
> >
> > There is, because you break all the users. All the distros, bootloaders
> > using this DTS, people's scripts.
> 
> I think that is a valid argument against renaming the toplevel .dts
> (and therefore .dtb), but renaming .dtsi should be a harmless internal
> detail to the kernel.  And less confusing, IMHO, than
> qsc9100-myboard.dts #including sa8775p.dtsi.
> 
> So wouldn't the sensible way forward be to rename .dtsi but not .dts?

FWIIW, and with the dual caveats that: I do not have the full context of
this series; and SoCs are not somewhere where I am active these days:

I am also under the impression that, in general, renames to
match product or other organisational changes are a non-starter.

But reading over this patchset, I also felt that renaming the .dsti files
would improve things. And seems to have little scope to break things for
users.

</2c>