linux-kernel - Re: [PATCH 4/5] net: mtk_eth_soc: fix device leak at probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250726204947.GT1367887@horms.kernel.org>
Date: Sat, 26 Jul 2025 21:49:47 +0100
From: Simon Horman <horms@...nel.org>
To: Johan Hovold <johan@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Madalin Bucur <madalin.bucur@....com>,
	Claudiu Manoil <claudiu.manoil@....com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Wei Fang <wei.fang@....com>, Clark Wang <xiaoning.wang@....com>,
	Felix Fietkau <nbd@....name>, Sean Wang <sean.wang@...iatek.com>,
	Lorenzo Bianconi <lorenzo@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	MD Danish Anwar <danishanwar@...com>,
	Roger Quadros <rogerq@...nel.org>,
	Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 4/5] net: mtk_eth_soc: fix device leak at probe

On Fri, Jul 25, 2025 at 07:12:12PM +0200, Johan Hovold wrote:
> The reference count to the WED devices has already been incremented when
> looking them up using of_find_device_by_node() so drop the bogus
> additional reference taken during probe.
> 
> Fixes: 804775dfc288 ("net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED)")
> Cc: stable@...r.kernel.org	# 5.19
> Cc: Felix Fietkau <nbd@....name>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>