linux-kernel - Re: [PATCH] fbdev: nvidiafb: add depends on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <09e7d9c0-3348-49d0-a390-372031652e97@gmx.de>
Date: Sun, 27 Jul 2025 19:28:53 +0200
From: Helge Deller <deller@....de>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: Arnd Bergmann <arnd@...nel.org>, Niklas Schnelle
 <schnelle@...ux.ibm.com>, Antonino Daplas <adaplas@...il.com>,
 linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] fbdev: nvidiafb: add depends on HAS_IOPORT

On 6/15/25 20:36, Randy Dunlap wrote:
> The nvidiafb driver uses inb()/outb() without depending on HAS_IOPORT,
> which leads to build errors since kernel v6.13-rc1:
> commit 6f043e757445 ("asm-generic/io.h: Remove I/O port accessors
> for HAS_IOPORT=n")
> 
> Add the HAS_IOPORT dependency to prevent the build errors.
> 
> (Found in ARCH=um allmodconfig builds)
> 
> drivers/video/fbdev/nvidia/nv_accel.c: In function ‘NVDmaWait’:
> include/asm-generic/io.h:596:15: error: call to ‘_outb’ declared with attribute error: outb() requires CONFIG_HAS_IOPORT
>    596 | #define _outb _outb
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Arnd Bergmann <arnd@...nel.org>
> Cc: Niklas Schnelle <schnelle@...ux.ibm.com>
> Cc: Antonino Daplas <adaplas@...il.com>
> Cc: Helge Deller <deller@....de>
> Cc: linux-fbdev@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> ---
>   drivers/video/fbdev/Kconfig |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

applied.

Thanks!
Helge


> 
> --- lnx-616-rc1.orig/drivers/video/fbdev/Kconfig
> +++ lnx-616-rc1/drivers/video/fbdev/Kconfig
> @@ -660,7 +660,7 @@ config FB_ATMEL
>   
>   config FB_NVIDIA
>   	tristate "nVidia Framebuffer Support"
> -	depends on FB && PCI
> +	depends on FB && PCI && HAS_IOPORT
>   	select FB_CFB_FILLRECT
>   	select FB_CFB_COPYAREA
>   	select FB_CFB_IMAGEBLIT
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 # v6.16-rc1