linux-kernel - Re: [PATCH] iio: xilinx-ams: Unmask interrupts after updating alarms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250727164336.385dda93@jic23-huawei>
Date: Sun, 27 Jul 2025 16:43:36 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Michal Simek <michal.simek@....com>
Cc: Sean Anderson <sean.anderson@...ux.dev>, Salih Erim
 <salih.erim@....com>, "O'Griofa, Conall" <conall.ogriofa@....com>, Anand
 Ashok Dumbre <anand.ashok.dumbre@...inx.com>, linux-iio@...r.kernel.org,
 David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, linux-arm-kernel@...ts.infradead.org, Andy Shevchenko
 <andy@...nel.org>, Manish Narani <manish.narani@...inx.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: xilinx-ams: Unmask interrupts after updating
 alarms

On Fri, 25 Jul 2025 06:47:16 +0200
Michal Simek <michal.simek@....com> wrote:

> On 7/24/25 17:32, Jonathan Cameron wrote:
> > On Mon, 14 Jul 2025 20:28:47 -0400
> > Sean Anderson <sean.anderson@...ux.dev> wrote:
> >   
> >> To convert level-triggered alarms into edge-triggered IIO events, alarms
> >> are masked when they are triggered. To ensure we catch subsequent
> >> alarms, we then periodically poll to see if the alarm is still active.
> >> If it isn't, we unmask it. Active but masked alarms are stored in
> >> current_masked_alarm.
> >>
> >> If an active alarm is disabled, it will remain set in
> >> current_masked_alarm until ams_unmask_worker clears it. If the alarm is
> >> re-enabled before ams_unmask_worker runs, then it will never be cleared
> >> from current_masked_alarm. This will prevent the alarm event from being
> >> pushed even if the alarm is still active.
> >>
> >> Fix this by recalculating current_masked_alarm immediately when enabling
> >> or disabling alarms.
> >>
> >> Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
> >> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>
> >> ---  
> > Anand?
> > 
> > This seems fine to me, but I'm not that familiar with the hardware or driver.  
> 
> Anand left some time ago. Salih or Conall should be able to provide some input.
> 
> Thanks,
> Michal
> 

Hi Michal,

Thanks for letting me know.  Would be good to have a MAINTAINERS update patch
to remove Anand + ideally add someone else.  If not to mark it orphaned
(will still be covered by the top level IIO entry).