linux-kernel - Re: [PATCH] bus: fsl-mc: Check return value of platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b107c2a6-bb56-4b15-bf0f-d9eca8163aa1@web.de>
Date: Sun, 27 Jul 2025 18:24:54 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Salah Triki <salah.triki@...il.com>, linuxppc-dev@...ts.ozlabs.org,
 Ioana Ciornei <ioana.ciornei@....com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bus: fsl-mc: Check return value of
 platform_get_resource()

> platform_get_resource() returns NULL in case of failure, so check its
> return value and propagate the error in order to prevent NULL pointer
> dereference.

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc7#n145


…
> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
> @@ -1105,6 +1105,10 @@ static int fsl_mc_bus_probe(struct platform_device *pdev)
>  	 * Get physical address of MC portal for the root DPRC:
>  	 */
>  	plat_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +
> +	if (!plat_res)
> +		return -ENODEV;
…

I suggest to omit a blank line before the if statement.

Regards,
Markus