linux-kernel - Re: team_change_rx flags sleeping with bh disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <688663bb.a00a0220.b12ec.0061.GAE@google.com>
Date: Sun, 27 Jul 2025 10:36:59 -0700
From: syzbot <syzbot+8182574047912f805d59@...kaller.appspotmail.com>
To: ujwal.kundur@...il.com
Cc: ujwal.kundur@...il.com, linux-kernel@...r.kernel.org, 
	syzkaller-bugs@...glegroups.com
Subject: Re: team_change_rx flags sleeping with bh disabled

> #syz test

This crash does not have a reproducer. I cannot test it.

>
> diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c
> index 8bc56186b2a3..4568075fea6e 100644
> --- a/drivers/net/team/team_core.c
> +++ b/drivers/net/team/team_core.c
> @@ -1778,7 +1778,7 @@ static void team_change_rx_flags(struct
> net_device *dev, int change)
>         struct team_port *port;
>         int inc;
>
> -       mutex_lock(&team->lock);
> +       spin_lock(&team->lock);
>         list_for_each_entry(port, &team->port_list, list) {
>                 if (change & IFF_PROMISC) {
>                         inc = dev->flags & IFF_PROMISC ? 1 : -1;
> @@ -1789,7 +1789,7 @@ static void team_change_rx_flags(struct
> net_device *dev, int change)
>                         dev_set_allmulti(port->dev, inc);
>                 }
>         }
> -       mutex_unlock(&team->lock);
> +       spin_unlock(&team->lock);
>  }
>
>  static void team_set_rx_mode(struct net_device *dev)
> -- 
> 2.30.2