linux-kernel - Re: [PATCH] rust/pin-init: remove workaround for type inference cycle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DBN16LSXVANU.1LMW8POGVF2CJ@kernel.org>
Date: Sun, 27 Jul 2025 19:58:30 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Suchit K" <suchitkarunakaran@...il.com>
Cc: <ojeda@...nel.org>, <alex.gaynor@...il.com>, <boqun.feng@...il.com>,
 <gary@...yguo.net>, <bjorn3_gh@...tonmail.com>, <a.hindborg@...nel.org>,
 <aliceryhl@...gle.com>, <tmgross@...ch.edu>, <dakr@...nel.org>,
 <me@...enk.dev>, <chrisi.schrefl@...il.com>,
 <rust-for-linux@...r.kernel.org>, <skhan@...uxfoundation.org>,
 <linux-kernel-mentees@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rust/pin-init: remove workaround for type inference
 cycle

On Sun Jul 27, 2025 at 7:44 PM CEST, Suchit K wrote:
> On Sun, 27 Jul 2025 at 22:58, Benno Lossin <lossin@...nel.org> wrote:
>> On Sun Jul 27, 2025 at 7:02 PM CEST, Suchit Karunakaran wrote:
>> > The `cast_pin_init` and `cast_init` functions previously used an
>> > intermediate `let` binding before returning the result expression to work
>> > around a Rust compiler issue causing type inference cycles. With the
>> > minimum Rust compiler version for the kernel now at 1.78.0, where this
>> > issue is fixed, the workaround is no longer needed. This patch removes the
>> > unnecessary `let` variables and returns the expressions directly.
>> >
>> > Signed-off-by: Suchit Karunakaran <suchitkarunakaran@...il.com>
>>
>> I still encounter the cycle when compiling with 1.78.0, which version
>> did you test this with?
>>
>
> Oops, I just realised that I compiled it locally and forgot that I had
> installed version 1.78.0 on my VM and not on my local system. I
> actually compiled it with version 1.88.0. Sorry for the inconvenience.

No worries.

>> Do note the comment mentioning that it is needed for version 1.78 here,
>> so I think this patch still needs to wait until we bump the minimum.
>>
>
> Yup got it. I'll send the patch after the minimum version is
> increased. Thanks for reviewing.

If you do, then please send the patch upstream at [1], that makes things
easier for me, thanks!

[1]: https://github.com/rust-for-linux/pin-init

---
Cheers,
Benno