linux-kernel - Re: [PATCH v3] Input: atkbd - Correctly map F13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wzlhkta4wtbsw3aieaesokg5gchiejrpraelhwlpzercz4q4z2@35a4dhjppno2>
Date: Sun, 27 Jul 2025 01:28:12 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Werner Sembach <wse@...edocomputers.com>
Cc: hansg@...nel.org, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Input: atkbd - Correctly map F13 - F24

On Tue, Jul 22, 2025 at 02:04:35PM +0200, Werner Sembach wrote:
> Currently only F23 is correctly mapped for PS/2 keyboards.
> 
> According to this table:
> https://download.microsoft.com/download/1/6/1/161ba512-40e2-4cc9-843a-923143f3456c/translate.pdf
> 
> - F24 and Zenkaku/Hankaku share the same scancode, but since in real world
> Zenkaku/Hankaku keys seem to just use the tilde scancode, this patch binds the
> scancode to F24. Note that on userspace side the KEY_ZENKAKUHANKAKU keycode is
> currently not bound in xkeyboard-config, so it is (mostly*) unused anyway.
> 
> * Qt on Wayland and therefore KDE on Wayland can see the keypress anyway for
> some reason and it is actually used in a touchpad toggle shortcut, but this is
> currently being fixed in both KDE and xkeyboard-config to make this less weird,
> so it could directly be fixed to correctly handle the F24 keypress instead.
> 
> - The scancodes for F13-F22 are currently unmapped so there will probably be no
> harm in mapping them. This would also fix the issue that some of these keys
> can't be mapped as the target from userspace using the `setkeycodes` command.
> 
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> Signed-off-by: Werner Sembach <wse@...edocomputers.com>

Applied, thank you.

-- 
Dmitry