linux-kernel - [PATCH v3] dt-bindings: iio: pressure: add invensense,icp10100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250728004039.8634-1-rodrigo.gobbi.7@gmail.com>
Date: Sun, 27 Jul 2025 21:32:02 -0300
From: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
To: jic23@...nel.org,
	dlechner@...libre.com,
	nuno.sa@...log.com,
	andy@...nel.org,
	conor+dt@...nel.org,
	krzk+dt@...nel.org,
	jean-baptiste.maneyrol@....com,
	robh@...nel.org
Cc: ~lkcamp/patches@...ts.sr.ht,
	linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: [PATCH v3] dt-bindings: iio: pressure: add invensense,icp10100

There is no txt file for it, add yaml for invensense,icp10100
which is already used in the driver. Also, document other compatibles
for ICP-101xx family and add invensense,icp10100 as a fallback.

Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>
Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
---
Just for the record from v2:

On 7/3/25 04:38, Krzysztof Kozlowski wrote:
> On Tue, Jul 01, 2025 at 07:05:43PM -0300, Rodrigo Gobbi wrote:
>> +$id: http://devicetree.org/schemas/iio/pressure/invensense,icp10100.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: InvenSense ICP-101xx Barometric Pressure Sensors
>> +
>> +maintainers:
>> +  - Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>
>> +
>> +description: |
>> +  Support for ICP-101xx family: ICP-10100, ICP-10101, ICP-10110, ICP-10111.
> 
> The problem with title and description here is that they do not match
> compatible. oneOf:
> 
> 1. Your statement is correct, but then compatibles are incomplete and
> will encourage people to use incomplete compatibles for e.g. ICP-10111.
> 2. Compatible is correct but your statement is not correct, so then fix
> the statement - drop other devices.
> 
> Assuming 1 is closer to truth, then I suggest to express it with
> documenting these compatibles and using invensense,icp10100 as fallback.
> 
> 
> Best regards,
> Krzysztof
> 
...reviewed the datasheet again and I think we should go with 1. I`ve changed that,
documented the rest of the family and added a fallback for it.
Tks and regards.

Changelog:
v3: add other compatible names and add a fallback for it
v2: https://lore.kernel.org/linux-devicetree/20250701221700.34921-1-rodrigo.gobbi.7@gmail.com/
v1: https://lore.kernel.org/all/20250626212742.7986-1-rodrigo.gobbi.7@gmail.com/
---
 .../iio/pressure/invensense,icp10100.yaml     | 50 +++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/pressure/invensense,icp10100.yaml

diff --git a/Documentation/devicetree/bindings/iio/pressure/invensense,icp10100.yaml b/Documentation/devicetree/bindings/iio/pressure/invensense,icp10100.yaml
new file mode 100644
index 000000000000..df875d6d03dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/pressure/invensense,icp10100.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/pressure/invensense,icp10100.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: InvenSense ICP-101xx Barometric Pressure Sensors
+
+maintainers:
+  - Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>
+
+description: |
+  Support for ICP-101xx family: ICP-10100, ICP-10101, ICP-10110, ICP-10111.
+  Those devices uses a simple I2C communication bus, measuring the pressure
+  in a ultra-low noise at the lowest power.
+  Datasheet: https://product.tdk.com/system/files/dam/doc/product/sensor/pressure/capacitive-pressure/data_sheet/ds-000186-icp-101xx.pdf
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - invensense,icp10101
+          - invensense,icp10110
+          - invensense,icp10111
+      - const: invensense,icp10100
+
+  reg:
+    maxItems: 1
+
+  vdd-supply: true
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        pressure@63 {
+            compatible = "invensense,icp10101", "invensense,icp10100";
+            reg = <0x63>;
+            vdd-supply = <&vdd_1v8>;
+        };
+    };
+...
-- 
2.48.1