linux-kernel - Re: [PATCH 1/3] arm64: dts: rockchip: Add SFC node for RK3528

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd253ee7-742b-4fdb-8ce2-4976d4578a3a@kwiboo.se>
Date: Mon, 28 Jul 2025 18:18:29 +0200
From: Jonas Karlman <jonas@...boo.se>
To: Chukun Pan <amadeus@....edu.cn>
Cc: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "heiko@...ech.de" <heiko@...ech.de>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-rockchip@...ts.infradead.org" <linux-rockchip@...ts.infradead.org>,
 "ziyao@...root.org" <ziyao@...root.org>
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Add SFC node for RK3528

Hi Chukun,

On 7/28/2025 9:00 AM, Chukun Pan wrote:
> Hi,
> 
>> +		sfc: spi@...00000 {
>> +			compatible = "rockchip,sfc";
>> +			reg = <0x0 0xffc00000 0x0 0x4000>;
>> +			interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&cru SCLK_SFC>, <&cru HCLK_SFC>;
>> +			clock-names = "clk_sfc", "hclk_sfc";
> 
> The clock* should be placed before interrupts.

Thanks for catching this, will fix in v2.

> BTW, doesn't the sfc node need to configure pinctrl?

Not sure if it make sense to have a default here. fspi_pins is most
likely always used, however fspi_csn0 and/or fspi_csn1 is probably board
specific.

On the Radxa E24C only fspi_csn0 and fspi_pins are used.

Regards,
Jonas

> 
> Thanks,
> Chukun
> 
> --
> 2.25.1
> 
>